Skip to content

feat(l1): allow overriding RocksDB config #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −108
Draft

feat(l1): allow overriding RocksDB config #4728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
377c1bd
default options
fedacking Sep 29, 2025
65d0d43
fix warnings
Oppen Oct 1, 2025
551a809
feat(l1): allow overriding RocksDB config
Oppen Oct 1, 2025
44d51d4
ref is ignored, so delete it
Oppen Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,5 @@ tower-http = { version = "0.6.2", features = ["cors"] }
rocksdb = "0.24.0"

[patch.crates-io]
rocksdb = { git = "https://github.com/Oppen/rust-rocksdb" }
secp256k1 = { git = "https://github.com/sp1-patches/rust-secp256k1", tag = "patch-0.30.0-sp1-5.0.0" }
115 changes: 11 additions & 104 deletions crates/storage/store_db/rocksdb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ use ethrex_common::{
};
use ethrex_trie::{Nibbles, NodeHash, Trie};
use rocksdb::{
BlockBasedOptions, BoundColumnFamily, Cache, ColumnFamilyDescriptor, MultiThreaded,
OptimisticTransactionDB, Options, WriteBatchWithTransaction,
BoundColumnFamily, ColumnFamilyDescriptor, MultiThreaded, OptimisticTransactionDB, Options,
WriteBatchWithTransaction,
};
use std::{collections::HashSet, path::Path, sync::Arc};
use tracing::info;
Expand Down Expand Up @@ -112,41 +112,15 @@ impl Store {
db_options.create_if_missing(true);
db_options.create_missing_column_families(true);

let cache = Cache::new_lru_cache(4 * 1024 * 1024 * 1024); // 4GB cache

db_options.set_max_open_files(-1);
db_options.set_max_file_opening_threads(16);

db_options.set_max_background_jobs(8);

db_options.set_level_zero_file_num_compaction_trigger(2);
db_options.set_level_zero_slowdown_writes_trigger(10);
db_options.set_level_zero_stop_writes_trigger(16);
db_options.set_target_file_size_base(512 * 1024 * 1024); // 512MB
db_options.set_max_bytes_for_level_base(2 * 1024 * 1024 * 1024); // 2GB L1
db_options.set_max_bytes_for_level_multiplier(10.0);
db_options.set_level_compaction_dynamic_level_bytes(true);

db_options.set_db_write_buffer_size(1024 * 1024 * 1024); // 1GB
db_options.set_write_buffer_size(128 * 1024 * 1024); // 128MB
db_options.set_max_write_buffer_number(4);
db_options.set_min_write_buffer_number_to_merge(2);

db_options.set_wal_recovery_mode(rocksdb::DBRecoveryMode::PointInTime);
db_options.set_max_total_wal_size(2 * 1024 * 1024 * 1024); // 2GB
db_options.set_wal_ttl_seconds(3600);
db_options.set_wal_bytes_per_sync(32 * 1024 * 1024); // 32MB
db_options.set_bytes_per_sync(32 * 1024 * 1024); // 32MB
db_options.set_use_fsync(false); // fdatasync

db_options.set_enable_pipelined_write(true);
db_options.set_allow_concurrent_memtable_write(true);
db_options.set_enable_write_thread_adaptive_yield(true);
db_options.set_compaction_readahead_size(4 * 1024 * 1024); // 4MB
db_options.set_advise_random_on_open(false);

// db_options.enable_statistics();
// db_options.set_stats_dump_period_sec(600);
db_options.enable_statistics();
db_options.set_stats_dump_period_sec(600);

// Current column families that the code expects
let expected_column_families = vec![
Expand Down Expand Up @@ -197,83 +171,16 @@ impl Store {

let mut cf_descriptors = Vec::new();
for cf_name in &all_cfs_to_open {
let mut cf_opts = Options::default();

cf_opts.set_level_zero_file_num_compaction_trigger(4);
cf_opts.set_level_zero_slowdown_writes_trigger(20);
cf_opts.set_level_zero_stop_writes_trigger(36);

match cf_name.as_str() {
CF_HEADERS | CF_BODIES => {
cf_opts.set_compression_type(rocksdb::DBCompressionType::Zstd);
cf_opts.set_write_buffer_size(128 * 1024 * 1024); // 128MB
cf_opts.set_max_write_buffer_number(4);
cf_opts.set_target_file_size_base(256 * 1024 * 1024); // 256MB

let mut block_opts = BlockBasedOptions::default();
block_opts.set_block_cache(&cache);
block_opts.set_block_size(32 * 1024); // 32KB blocks
block_opts.set_cache_index_and_filter_blocks(true);
cf_opts.set_block_based_table_factory(&block_opts);
}
CF_CANONICAL_BLOCK_HASHES | CF_BLOCK_NUMBERS => {
cf_opts.set_compression_type(rocksdb::DBCompressionType::Lz4);
cf_opts.set_write_buffer_size(64 * 1024 * 1024); // 64MB
cf_opts.set_max_write_buffer_number(3);
cf_opts.set_target_file_size_base(128 * 1024 * 1024); // 128MB

let mut block_opts = BlockBasedOptions::default();
block_opts.set_block_cache(&cache);
block_opts.set_block_size(16 * 1024); // 16KB
block_opts.set_bloom_filter(10.0, false);
block_opts.set_cache_index_and_filter_blocks(true);
cf_opts.set_block_based_table_factory(&block_opts);
}
CF_STATE_TRIE_NODES | CF_STORAGE_TRIES_NODES => {
cf_opts.set_compression_type(rocksdb::DBCompressionType::Lz4);
cf_opts.set_write_buffer_size(512 * 1024 * 1024); // 512MB
cf_opts.set_max_write_buffer_number(6);
cf_opts.set_min_write_buffer_number_to_merge(2);
cf_opts.set_target_file_size_base(256 * 1024 * 1024); // 256MB
cf_opts.set_memtable_prefix_bloom_ratio(0.2); // Bloom filter

let mut block_opts = BlockBasedOptions::default();
block_opts.set_block_size(16 * 1024); // 16KB
block_opts.set_block_cache(&cache);
block_opts.set_bloom_filter(10.0, false); // 10 bits per key
block_opts.set_cache_index_and_filter_blocks(true);
block_opts.set_pin_l0_filter_and_index_blocks_in_cache(true);
cf_opts.set_block_based_table_factory(&block_opts);
}
CF_RECEIPTS | CF_ACCOUNT_CODES => {
cf_opts.set_compression_type(rocksdb::DBCompressionType::Lz4);
cf_opts.set_write_buffer_size(128 * 1024 * 1024); // 128MB
cf_opts.set_max_write_buffer_number(3);
cf_opts.set_target_file_size_base(256 * 1024 * 1024); // 256MB

let mut block_opts = BlockBasedOptions::default();
block_opts.set_block_cache(&cache);
block_opts.set_block_size(32 * 1024); // 32KB
block_opts.set_block_cache(&cache);
cf_opts.set_block_based_table_factory(&block_opts);
}
_ => {
// Default for other CFs
cf_opts.set_compression_type(rocksdb::DBCompressionType::Lz4);
cf_opts.set_write_buffer_size(64 * 1024 * 1024); // 64MB
cf_opts.set_max_write_buffer_number(3);
cf_opts.set_target_file_size_base(128 * 1024 * 1024); // 128MB

let mut block_opts = BlockBasedOptions::default();
block_opts.set_block_size(16 * 1024);
block_opts.set_block_cache(&cache);
cf_opts.set_block_based_table_factory(&block_opts);
}
}

let cf_opts = Options::default();
cf_descriptors.push(ColumnFamilyDescriptor::new(cf_name, cf_opts));
}

if let Ok(opts_str) = std::env::var("ETHREX_ROCKSDB_OPTIONS_OVERRIDE") {
db_options = db_options
.get_options_from_string(opts_str)
.unwrap_or(db_options);
}

let db = OptimisticTransactionDB::<MultiThreaded>::open_cf_descriptors(
&db_options,
path,
Expand Down
Loading