Skip to content

chore(l1): Deprecate unused discv4 API and remove stale allow/TODOs #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(l1): Deprecate unused discv4 API and remove stale allow/TODOs #5090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions crates/networking/p2p/discv4/messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ pub enum PacketDecodeErr {
HashMismatch,
#[error("Invalid signature")]
InvalidSignature,
#[deprecated(
note = "Unused; consolidate on other variants. Will be removed in a future release."
)]
#[error("Discv4 decoding error: {0}")]
Discv4DecodingError(String),
#[error("Io Error: {0}")]
Expand Down Expand Up @@ -249,8 +252,6 @@ impl PingMessage {
}
}

// TODO: remove when used
#[allow(unused)]
pub fn with_enr_seq(self, enr_seq: u64) -> Self {
Self {
enr_seq: Some(enr_seq),
Expand Down Expand Up @@ -281,7 +282,6 @@ pub struct FindNodeMessage {
}

impl FindNodeMessage {
#[allow(unused)]
pub fn new(target: H512, expiration: u64) -> Self {
Self { target, expiration }
}
Expand All @@ -308,6 +308,9 @@ impl RLPDecode for FindNodeMessage {
}

#[derive(Debug, Clone)]
#[deprecated(
note = "Unused internal type; find-node tracking is handled by PeerTable/DiscoveryServer. Will be removed in a future release."
)]
pub struct FindNodeRequest {
/// the number of nodes sent
/// we keep track of this number since we will accept neighbor messages until the max_per_bucket
Expand All @@ -330,6 +333,9 @@ impl Default for FindNodeRequest {
}

impl FindNodeRequest {
#[deprecated(
note = "Unused internal type; use PeerTable for tracking. Will be removed in a future release."
)]
pub fn new_with_sender(sender: tokio::sync::mpsc::UnboundedSender<Vec<Node>>) -> Self {
Self {
tx: Some(sender),
Expand Down Expand Up @@ -374,7 +380,6 @@ pub struct PongMessage {
}

impl PongMessage {
#[allow(unused)]
pub fn new(to: Endpoint, ping_hash: H256, expiration: u64) -> Self {
Self {
to,
Expand Down
Loading