Chiller plant sequences by milicag · Pull Request #2299 · lbl-srg/modelica-buildings

milicag · 2020-12-08T23:16:05Z

Closes #2293, #2086, #1977.

AntoineGautier

This feedback is for commit 3f8c79f.

It seems that the remarks from #2299 (comment) have not been addressed.
This is problematic as several bugs were reported.

In addition, the main controller is still incompatible with a large subset of all possible plant configurations. But there is no assert statements in the code to check that the configuration settings are actually supported. So the user can only refer to the documentation of the main controller. This documentation enumerates all subcontrollers and provides for each of them a table showing which configurations are covered. So one must browse through all those tables to deduce which configurations the main controller is actually compatible with.
Furthermore, it appears that some subcontrollers are only valid for primary-secondary configurations (such as Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Staging.SetPoints.Subsequences.CapacityRequirement--although this is not explicit in the documentation--which uses the secondary CHW return temperature and references §5.2.4.8 from RP1711) while others are only valid for primary-only configurations (such as Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Pumps.ChilledWater.Controller).

I also have several additional inline remarks, see below.

AntoineGautier · 2022-10-13T13:51:46Z

+  parameter Real fanSpeMin(unit="1")=0.1
+                        "Minimum tower fan speed"
+    annotation (Dialog(tab="Cooling Towers", group="Fan speed"));
+
+  parameter Real fanSpeMax(unit="1")=1
+                      "Maximum tower fan speed"
+    annotation (Dialog(tab="Cooling Towers", group="Fan speed"));


First parameter only required for water-cooled plants.

Second parameter never required as 100% AO from the BAS shall be mapped to maximum speed.

@JayHuLBL This remains partially unaddressed in 79f8bfe:

fanSpeMax never required as 100% AO from the BAS shall be mapped to maximum speed.

@JayHuLBL This remains unaddressed in 55ea8c5.

AntoineGautier · 2022-10-14T13:29:28Z

+  Buildings.Controls.OBC.CDL.Interfaces.RealInput TConWatSup(
+    final unit="K",
+    displayUnit="degC",
+    final quantity="ThermodynamicTemperature") if not closeCoupledPlant
+    "Condenser water supply temperature (condenser entering)"
+    annotation(Placement(transformation(extent={{-940,-680},{-900,-640}}),
+      iconTransformation(extent={{-140,-340},{-100,-300}})));


Missing condition for type of CT fan speed control.
In pseudo code this should be if have_CWRTControl and not closeCoupledPlant or have_CWSTControl.

@JayHuLBL This remains partially unaddressed in 79f8bfe:

The condition is now if not closeCoupledPlant and not have_airCoo: does this mean that only CWRT control is implemented? Is this limitation mentioned somewhere?

@JayHuLBL The question remains open in 55ea8c5:

The condition is now if not closeCoupledPlant and not have_airCoo: does this mean that only CWRT control is implemented? Is this limitation mentioned somewhere?

AntoineGautier · 2023-02-27T14:25:30Z

For reference, I am tracking here another suspected bug as discussed on 2/3/23.
The issue is within Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Pumps.ChilledWater.Controller where a pre block is used to check with intEqu4 the pump proven ON status (i.e. enable command equals pump status). However, in the validation model Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Pumps.ChilledWater.Validation.Controller the pump status passed in as input to heaNoLoc is also computed using a pre block (enaStaRet). So inside the controller, intEqu4 should always return true as it basically compares pre(heaNoLoc.yChiWatPum) to heaNoLoc.uChiWatPum which is connected to pre(heaNoLoc.yChiWatPum).
I slightly modified the validation model (attached) to exhibit what I think is an incorrect response of the controller. See the plot below:

Controller.mo.txt

[EDIT on 1/20/25] On commit f1e3de2, the issue seems to persist with the staging logic for headered pumps. The validation model Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Pumps.ChilledWater.Validation.Controller shows that only the lead pump is enabled. The lag pumps remain disabled (even when reducing the frequency of the source signal for the CHW flow rate to ensure that the minimum runtime before triggering stage change has been reached). Consider refactoring by simply computing the stage up and stage down command signals and using Templates.Plants.Controls.Utilities.StageIndex which is a generic implementation of the stage index evaluation that also accounts for unavailable stages.

[EDIT on 9/29/25] @JayHuLBL There still seems to be an issue with the primary CHW pump staging logic in commit 55ea8c5. The validation model Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Pumps.ChilledWater.Validation.Controller shows that only the first lag pump (#1) is enabled. The second lag pump (#3) is never enabled despite the primary flow ratio exceeding 2/3 - 0.03 for more than 10'.

…ng detailed sequence applicabilities [ci skip]

JayHuLBL · 2026-05-20T23:40:50Z

@AntoineGautier The remaining issue about the economizer tuning parameter calculation was addressed. The change was tested in template model as below. The tuning parameter will change as expected.

AntoineGautier · 2026-05-21T08:54:17Z

@JayHuLBL Great! One question though: why is the tuning parameter not increased around 7E4 s of simulation time based on the following clause?

Increase “m” by 0.02 when the economizer is disabled if the economizer remained enabled for less
than 30 minutes and WseTower-MaxSpeed did not decrease below 100% speed while the WSE
was enabled.

JayHuLBL · 2026-05-21T21:14:08Z

@AntoineGautier There was a confusion about the "WseTower-MaxSpeed did not decrease below 100% speed while the WSE was enabled." We need to check if the speed was alway not less than 100% during the entire period when the WSE was enabled, rather than at the specific moment, i.e. when the WSE was enabled.

I believe it has been corrected now through the commit 67ee039.

AntoineGautier · 2026-05-22T15:34:13Z

@JayHuLBL Thanks, that looks good.

JayHuLBL · 2026-06-01T23:41:36Z

@mwetter
It's ready to merge if there is no more comment.

mwetter

@JayHuLBL : See some high level feedback from a quick review.

mwetter · 2026-06-02T20:28:55Z

@@ -17,6 +17,11 @@ The following <b style=\"color:blue\">new libraries</b> have been added:
    <td valign=\"top\">xxx.
    </td>
    </tr>
+<tr><td valign=\"top\">Buildings.Controls.OBC.ASHRAE.G36.Plants
+    </td>
+    <td valign=\"top\">Package of sequences for chiller and boiler plants


There are no boiler plants in the PR

Deleted the boiler plants text.

mwetter · 2026-06-02T20:30:39Z

Check out file from master, otherwise it will be overridden again when we merge IBPSA. This change seems not needed.

Checked out the file from master.

JayHuLBL · 2026-06-08T17:29:24Z

@mwetter Ready for review.

JayHuLBL · 2026-07-09T16:55:22Z

Before merging, Todo:

Remove the Buildings.Templates.Plants.Controls.Utilities.TimerWithReset, as it is a duplicate of Buildings.Controls.OBC.ASHRAE.G36.Plants.Chillers.Generic.TimerWithReset.

milicag marked this pull request as ready for review December 10, 2020 06:01

This comment was marked as outdated.

Sign in to view

milicag mentioned this pull request May 10, 2021

Remove parameter evaluation for applicable parameters after Modelon fix #2086

Closed

JayHuLBL self-assigned this May 24, 2021

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

AntoineGautier requested changes Oct 14, 2022

View reviewed changes

AntoineGautier reviewed Oct 18, 2022

View reviewed changes

Comment thread Buildings/Controls/OBC/ASHRAE/PrimarySystem/ChillerPlant/Controller.mo Outdated

AntoineGautier reviewed Oct 18, 2022

View reviewed changes

Comment thread Buildings/Controls/OBC/ASHRAE/PrimarySystem/ChillerPlant/Controller.mo Outdated

AntoineGautier reviewed Oct 18, 2022

View reviewed changes

Comment thread Buildings/Controls/OBC/ASHRAE/PrimarySystem/ChillerPlant/Controller.mo Outdated

AntoineGautier reviewed Oct 21, 2022

View reviewed changes

Comment thread Buildings/Controls/OBC/ASHRAE/PrimarySystem/ChillerPlant/Controller.mo Outdated

This comment was marked as resolved.

Sign in to view

AntoineGautier mentioned this pull request Feb 28, 2023

Templates • CHW plant #3167

Draft

5 tasks

mwetter added this to the Release 10.0 milestone Mar 8, 2023

This comment was marked as resolved.

Sign in to view

mwetter modified the milestones: Release 10.0, Release 11.0 Sep 5, 2023

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

AntoineGautier mentioned this pull request Apr 1, 2024

Add hold/release signal to TrimAndRespond block #3761

Closed

JayHuLBL added 6 commits June 26, 2024 14:26

Merge branch 'master' into issue2293_chiller_plant_seq

16e3b70

updating controller documentation [ci skip]

e43b0a4

Merge branch 'master' into issue2293_chiller_plant_seq

66e6e9b

updated closed-loop diagram, changed staging setpoint reference, addi…

694cca3

…ng detailed sequence applicabilities [ci skip]

Merge branch 'master' into issue2293_chiller_plant_seq

4468d18

added documentation

7e09830

JayHuLBL added 3 commits May 18, 2026 11:06

fixed typos

fe12ae1

fixed typos in Example.ChillerPlants package

be48be7

corrected economizer tuning parameter calculation

b68050d

improved calculation of the economizer tuning parameter

67ee039

Merge branch 'master' into issue2293_chiller_plant_seq

6b811c6

JayHuLBL added 6 commits May 26, 2026 13:01

applied single process setting for the OME test

5fd8f70

Merge branch 'master' into issue2293_chiller_plant_seq

c3e0100

added missing conditional connection

8b185a4

added missing conditional connection

4af8de2

merged master

089285f

improved text [ci skip]

f89836a

mwetter self-assigned this Jun 2, 2026

mwetter requested changes Jun 2, 2026

View reviewed changes

JayHuLBL added 8 commits June 2, 2026 14:04

updated note to avoid including boiler plants

8a64bc4

checked out unnecessary changes

b31af51

renamed the Example.ChillerPlants package

ac062bc

renamed the Example.ChillerPlants package

f9001c6

recreated chiller schematic drawings to have the svg version

d923c0d

moved timerwithReset back to the generic package

b87ed9e

avoided using new timer

41c341a

implemented TimerWithReset as composed block

ae88aad

AntoineGautier mentioned this pull request Jul 9, 2026

Enhance AWHP plant template to support 4-pipe heat pumps #4657

Open

Merge branch 'master' into issue2293_chiller_plant_seq

1da7858

Uh oh!

Conversation

milicag commented Dec 8, 2020

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

Uh oh!

AntoineGautier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AntoineGautier Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

AntoineGautier commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

JayHuLBL commented May 20, 2026

Uh oh!

AntoineGautier commented May 21, 2026

Uh oh!

JayHuLBL commented May 21, 2026

Uh oh!

AntoineGautier commented May 22, 2026

Uh oh!

JayHuLBL commented Jun 1, 2026

Uh oh!

mwetter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JayHuLBL commented Jun 8, 2026

Uh oh!

JayHuLBL commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

AntoineGautier Sep 29, 2025 •

edited

Loading

AntoineGautier commented Feb 27, 2023 •

edited

Loading