Skip to content

Fix close cleanup in real race env #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuming-Lee24 wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −18
Open

Fix close cleanup in real race env #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lsy_drone_racing/envs/real_race_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,11 +449,9 @@ def close(self):
Irrespective of succeeding or not, the drone will be stopped immediately afterwards or in
case of errors, and close the connections to the ROSConnector.
"""
if not self.data.drone_connected or not self.data.taken_off:
self._ros_connector.close()
return
try:
self._return_to_start()
if self.data.taken_off:
self._return_to_start()
finally:
try:
# Kill the drone
Expand Down
15 changes: 1 addition & 14 deletions pixi.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading