Cell step param scaling #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scaling of cell steps. Improve documentation of these parameters.
Definitely use default scale cell shear steps that are multiplied by typical length scale.
Consider whether shear steps need to be circular in plane of two cell vectors, or whether current elliptical is OK.
Consider whether stretch steps, which multiply existing vectors, suffer from same issue that make it wrong to multiply cell volume by a max percentage.Pretty confident that the use ofexp(rv)for stretch steps makes it reversible. Consider using the same approach for volume steps. Decided to leave that for a future PR, and created #28 to remind us.closes #26