feat(upnp): emit local listen address when a port is mapped - #6121
Conversation
5eb0066 to
2a26c4e
Compare
jxs
left a comment
There was a problem hiding this comment.
Hi, and thanks for this!
Can you split this into the 3 different PR's? (preferably in a sequential way)
We prefer to have a small CHANGELOG.md entry linking to a PR that explains and shows the conversation for the PR itself
I work in the same team as Roland, and I'm sure it would be possible. I wanted to ask about doing a release fairly soon after the PRs were merged. Would that be possible? |
2a26c4e to
a2e2fcc
Compare
a2e2fcc to
9efc000
Compare
9efc000 to
8a5d519
Compare
8a5d519 to
885852d
Compare
jxs
left a comment
There was a problem hiding this comment.
LGTM! @RolandSherwin, can you fix the conflicts?
Thanks
|
This pull request has merge conflicts. Could you please resolve them @RolandSherwin? 🙏 |
885852d to
e84dbb9
Compare
|
Fixed it, thanks @jxs! |
|
Hey @jxs , would it be possible to do a new release of libp2p with these new changes? These changes are required for a feature inside the Autonomi Project that I'm working on. Thank you! |
Description
This PR aims to expose the local listen address for a corresponding successful port-map to the end user. It would be great to know which local adapter was successfully mapped, when the user has multiple local adapters that they're listening on.
Note: #6127 and #6128 were part of the original PR.
Change checklist