fix(upnp): add exponential backoff for failed port mappings - #6128
Merged
mergify[bot] merged 1 commit intoSep 1, 2025
Conversation
4 tasks
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
August 13, 2025 05:15
d6569d8 to
fc36065
Compare
jxs
approved these changes
Aug 22, 2025
jxs
left a comment
jxs
left a comment
Member
There was a problem hiding this comment.
Hi, and thanks for this!
Overall looks good to me, left a question
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
August 26, 2025 01:53
fc36065 to
2608566
Compare
ackintosh
reviewed
Aug 30, 2025
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
August 31, 2025 11:12
2608566 to
ecc1153
Compare
jxs
approved these changes
Sep 1, 2025
jxs
left a comment
jxs
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! And Thanks Akihito for the help with the review
mergify Bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
This PR aims to expose the local listen address for a corresponding successful port-map to the end user. It would be great to know which local adapter was successfully mapped, when the user has multiple local adapters that they're listening on. Note: #6127 and #6128 were part of the original PR. Pull-Request: #6121.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit aims to fix an infinite retry loop of failed mappings. We now have an exponential backoff and would retry any failed mappings upto 5 times before giving up.
Change checklist