Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

Add comments to prevent future confusion (and having to re-derive the formulas)

@jeremykubica jeremykubica requested a review from mi-dai October 28, 2025 13:57
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (72fdad4) to head (6eea2f7).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   91.22%   91.19%   -0.03%     
==========================================
  Files          61       61              
  Lines        4899     4952      +53     
==========================================
+ Hits         4469     4516      +47     
- Misses        430      436       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Before [6da7ad8] After [ffd9bcd] Ratio Benchmark (Parameter)
544±2μs 569±6μs 1.05 benchmarks.TimeSuite.time_apply_passbands
12.5±0.2μs 13.0±0.09μs 1.04 benchmarks.TimeSuite.time_sample_x1_from_hostmass
4.60±0.07ms 4.71±0.07ms 1.03 benchmarks.TimeSuite.time_lightcurve_source
108±1μs 111±0.7μs 1.03 benchmarks.TimeSuite.time_sample_x0_from_distmod
88.0±2μs 89.6±0.8μs 1.02 benchmarks.TimeSuite.time_make_and_evaluate_step_model
29.2±0.2μs 29.7±0.2μs 1.02 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
33.0±0.3ms 33.3±0.6ms 1.01 benchmarks.TimeSuite.time_additive_multi_model_source
19.3±0.3ms 19.6±0.2ms 1.01 benchmarks.TimeSuite.time_chained_evaluate_sed
4.41±0.09ms 4.45±0.05ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_passbands
8.00±0.02ms 8.06±0.04ms 1.01 benchmarks.TimeSuite.time_load_passbands

Click here to view all benchmarks.

@jeremykubica jeremykubica requested a review from mi-dai October 29, 2025 11:59
@jeremykubica jeremykubica merged commit 110f03d into main Oct 29, 2025
8 of 9 checks passed
@jeremykubica jeremykubica deleted the redshift_comment branch October 29, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants