Skip to content

Add comments about the redshift correction #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

Add comments about the redshift correction #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
329e81e
Add comments about the redshift correction
jeremykubica Oct 28, 2025
6eea2f7
Rephrase comment
jeremykubica Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lightcurvelynx/astro_utils/redshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ def rest_to_obs_flux(flux_density, redshift):
flux_density : numpy.ndarray
The observer frame flux (in nJy).
"""
# Note that the multiplication by (1+z) is due to the fact we are working in f_nu units,
# instead of f_lambda units and may be unintuitive for users who are used to working in f_lambda
# units. This factor can be derived by equaling the integrated flux in f_nu unit before and after
# redshift is applied.
return flux_density * (1 + redshift)


Expand Down
4 changes: 4 additions & 0 deletions tests/lightcurvelynx/astro_utils/test_redshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ def test_redshifted_flux_densities() -> None:

for i, time in enumerate(times):
if t0 <= time and time <= (t1 - t0) * (1 + redshift) + t0:
# Note that the multiplication by (1+z) is due to the fact we are working in f_nu
# units, instead of f_lambda units and may be unintuitive for users who are used to
# working in f_lambda units. This factor can be derived by equaling the integrated
# flux in f_nu unit before and after redshift is applied.
assert np.all(values_redshift[i] == brightness * (1 + redshift))
else:
assert np.all(values_redshift[i] == 0.0)
Expand Down