Add push flag to data stream header #1208
Conversation
🦋 Changeset detectedLatest commit: 1828b65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| string topic = 3; | ||
| string mime_type = 4; | ||
| optional uint64 total_length = 5; // only populated for finite streams, if it's a stream of unknown size this stays empty | ||
| bool push = 6; // stream should be pushed to destination participants without requiring them to explicitly accept it. |
There was a problem hiding this comment.
it does more than "just" push though, right? It also internally collects the stream and only forwards the "complete" value.
we could think about making total_length required for push cases as well.
There was a problem hiding this comment.
Yes, that's correct; maybe it should be called something other than push? I agree, total_length should be required when "push" is enabled. I can also see possibly adding an option on the receiving end to reject pushed streams over a specified length.
|
No longer being considered |
This PR adds a
pushflag to the data stream header to facilitate the new behavior forsendTextandsendBytesin which streams are automatically read and dispatched by the receiver:WIP implementation in Rust, currently using an internal attribute in place of this flag: