Skip to content

Add push flag to data stream header #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add push flag to data stream header #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de0285e
Add push flag to data stream header
ladvoc Sep 12, 2025
1c28d3a
generated protobuf
github-actions[bot] Sep 12, 2025
1828b65
Add changeset
ladvoc Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-toes-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"github.com/livekit/protocol": patch
---

Add push flag to data stream header
15 changes: 12 additions & 3 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,7 @@ message DataStream {
string topic = 3;
string mime_type = 4;
optional uint64 total_length = 5; // only populated for finite streams, if it's a stream of unknown size this stays empty
bool push = 6; // stream should be pushed to destination participants without requiring them to explicitly accept it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does more than "just" push though, right? It also internally collects the stream and only forwards the "complete" value.

we could think about making total_length required for push cases as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct; maybe it should be called something other than push? I agree, total_length should be required when "push" is enabled. I can also see possibly adding an option on the receiving end to reject pushed streams over a specified length.

Encryption.Type encryption_type = 7 [deprecated=true]; // this is set on the DataPacket
map<string, string> attributes = 8; // user defined attributes map that can carry additional info

Expand Down
Loading