[HW][SV] Allow procedural SV ops in hw::TriggeredOp #7314
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the SV dialect
ProceduralOp
/NonProceduralOp
traits to considerhw::TriggeredOp
a procedural region. This should enable us to lower the procedural operations within ahw::TriggeredOp
region before lowering the entire module.See the discussion in #7292. We currently do not have a cross-dialect notion of procedural regions. However, the description of
hw::TriggeredOp
states bluntly that it creates a procedural region, so I think this is a relatively intuitive change.Piggybacked are two sanity checks for
hw::TriggeredOp
: