Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add layers output file to file list #7543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpriteOvO
Copy link
Member

Fixes #7542. @FanShupei Could you try if this PR fixes the issue?

@seldridge
Copy link
Member

I thought about making this change, too. I went another direction with ChiselSim, though, which was to have it look for files that are layer enable files and include the ones that enable the layers the user wants.

I.e., the filelist today can be used to compile the design without any layers enabled. This would change this to mean the filelist will compile the design with all layers enabled. If we keep the filelist, it seems like we just have to choose one of these.

How were you thinking of using this?

@sequencer
Copy link
Contributor

sequencer commented Aug 22, 2024

I personally like the idea of removing the entire filelist.f. because of the lack of consistent ABI for it. random user will get trap because of issue like this. Maybe a new API to query MLIR might be possible?
e.g. query all public module, query different layers, query memory metadatas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIRTOOL] Verification layers are not included in filelist.f
3 participants