Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SV] Add MacroRefOp to represet macro statement #7607

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Sep 18, 2024

There has been MacroRefExprOp and MacroRefExprSEOp to use macro symbols as expressions but it was not possible to use macro as a statement. This commit adds sv.macro.ref op to represent a statement. Since sv.macro.ref mnemonic was used by MacroRefExprOp this commit also renames sv.macro.ref to sv.macro.ref.expr at the same time.

There has been MacroRefExprOp and MacroRefExprSEOp to use macro
symbols as expressions but it was not possible to use macro as a
statement. This commit adds `sv.macro.ref` op to represent a
statement.
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This was an obviously missing feature. Thanks!

include/circt/Dialect/SV/SVStatements.td Outdated Show resolved Hide resolved
test/Conversion/ExportVerilog/sv-dialect.mlir Show resolved Hide resolved
@uenoku uenoku merged commit f8a95aa into main Sep 25, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/macro branch September 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants