[MemoryBanking] Bank memref::copy logically using memref::subView #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i.e., doesn't need to bank the memory reference physically)
cgyurgyik
reviewed
Jan 13, 2025
| return failure(); | ||
|
|
||
| ArrayRef<int64_t> dstShape = dstType.getShape(); | ||
| int64_t chunkSize = dstShape[bankingDimension] / (int64_t)bankingFactor; |
There was a problem hiding this comment.
Please avoid implicit casts (here and above and below).
Suggested change
| int64_t chunkSize = dstShape[bankingDimension] / (int64_t)bankingFactor; | |
| int64_t chunkSize = dstShape[bankingDimension] / static_cast<int64_t>(bankingFactor); |
|
|
||
| ArrayRef<int64_t> srcShape = srcType.getShape(); | ||
| // We'll assume static shapes and exact divisibility. | ||
| int64_t chunkSize = srcShape[bankingDimension] / (int64_t)bankingFactor; |
There was a problem hiding this comment.
same thing here, prefer explicit cast vs implicit.
| /// Copy from unbanked source memref `srcMem` to destination memory references | ||
| /// `dstBanks`, where each bank has the same MemRefType, and `srcMem` has the | ||
| /// shape of the "original" unbanked array. | ||
| LogicalResult copyFromUnbankedToBanks(PatternRewriter &rewriter, Location loc, |
There was a problem hiding this comment.
This seems to be almost exactly the same as the function above. Can we add additional arguments or template parameters to avoid having two nearly duplicate functions? WDYT?
| Value dstMem = copyOp.getTarget(); | ||
|
|
||
| bool srcIsBanked = memoryToBanks.count(srcMem) != 0; | ||
| bool dstIsBanked = memoryToBanks.count(dstMem) != 0; |
There was a problem hiding this comment.
Again, a good habit here to avoid double lookups is
auto srcIt = memoryToBanks.find(srcMem);
auto dstIt = memoryToBanks.find(dstMem);
bool srcIsBanked = srcIt != memoryToBanks.end();
bool dstIsBanked = dstIt != memoryToBanks.end();
...
auto& srcBanks = srcIt->second;| if (d == bankingDimension) { | ||
| // Round-robin partition: offset = bankIndex, size = chunkSize, stride = | ||
| // bankingFactor | ||
| int64_t chunkSize = dimSize / (int64_t)bankingFactor; |
cgyurgyik
reviewed
Jan 13, 2025
| @@ -409,6 +409,151 @@ struct BankAffineStorePattern | |||
| DenseSet<Value> &oldMemRefVals; | |||
| }; | |||
|
|
|||
| struct BankMemrefCopyPattern : public OpRewritePattern<memref::CopyOp> { | |||
There was a problem hiding this comment.
Add a comment here please describing the purpose/goal of this rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch banks
memref::copyop logically when the operation is not used in parallel ops (which implies that we don't need to create new physical memories) by usingmemref::subViewop.