[CIR] Add move ctor and move/copy assignment to CXXSpecialMemberAttr
#1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommymcm
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tommymcm
force-pushed
the
cxx_special_member-assign-and-move-ctor
branch
from
5b5f261 to
0abca38
Compare
xlauko
approved these changes
Sep 4, 2025
|
Add test that exercises print/parse of |
tommymcm
force-pushed
the
cxx_special_member-assign-and-move-ctor
branch
2 times, most recently
from
4359a82 to
df72729
Compare
|
Seems to be failing some tests on macOS and ubuntu |
tommymcm
force-pushed
the
cxx_special_member-assign-and-move-ctor
branch
from
859eec8 to
e5f01ee
Compare
CI is green after rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cir::CtorKind::MovetoCXXCtorAttrfor move constructorsAdd
cir::CXXAssignAttrwithcir::AssignKind::{Move,Copy}for move/copy assignment operatorsPer discussion in #1879
Updated lifetime checker to use the
CXXAssignAttrinstead of AST interface.I will be making a PR that depends on
cir::CXXCtorKind::Movesoon.