Test/MCP UI workspace opening an app replaces the welcome page with a dock - #344
Open
romanzac wants to merge 19 commits into
Open
Test/MCP UI workspace opening an app replaces the welcome page with a dock#344romanzac wants to merge 19 commits into
romanzac wants to merge 19 commits into
Conversation
…suite time budget
…IT gates, xfail runner) and rea
…nc launcherApps refresh
…R gate scans real output
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add the stable automation handles enumerated in spec §4.1, following
the existing sidebar.app.<name> / confirmationDialog.<mode>.<button>
convention: welcomePage.installNow, appManager.{searchField,
category.<name>,emptyView}, appContextMenu root,
addApplicationDialog.{primaryButton,closeButton,errorText,
resolutionBanner}, settings.searchField,
pluginInterface.{call.<method>,result,back}, repositories.{urlField,
addButton,refreshButton,errorBanner,errorDismiss,row.<url>,
removeConfirm.{confirm,cancel}}, and sidebar.buildLabel.
workspace.dock.<name> is deliberately not applied: the dock root's
objectName is pinned to the bare module name by
workspace_area_test.cpp and needs a coordinated rename (recorded as
a finding).
Add fixture A (test_qml_only v0.1.1, ui_qml) and a seedPlugin(userDir, fixture) helper to tests/fixtures/lgx.mjs, and seed it into <user-dir>/plugins/ in nix/integration-test.nix before the app launches (MCP-TEST-PLAN v2 §0.A/§4.7). package_manager's installed lists are live directory scans for <name>/manifest.json, so the seeded fixture shows up in launcherApps at boot without any install IPC, giving sidebar/dock tests a real launcher app. A1 takes its "Welcome back" branch.
Add spec MCP-TEST-PLAN v2 §2.A test A3: clicking fixture A's sidebar tile (obj sidebar.app.test_qml_only) must set backend.currentVisibleApp, create exactly one workspace dock, hide the welcome page, and render the fixture's v0.1.1 payload text. The dock assertion reads WorkspaceArea.dockCount via the objectName "workspace" test hook, since the workspace.dock.<name> objectName does not exist on this branch (DockCard's objectName is the constant "dockCard"). Welcome visibility is read off the hosting QQuickWidget — updateWelcomeVisibility() hides the widget, not the QML item — located by its WelcomePage.qml source URL, with a Window.visible fallback. Per spec §0.A the test skips (instead of failing) when attached to a locally running app without the pre-seeded fixture; in --ci mode the fixture is seeded at boot, so absence there fails. The dock is left open at the end — the A4 follow-up owns close-the-dock coverage.
Collaborator
Jenkins BuildsClick to see older builds (8)
|
8 tasks
📊 basecamp doc-test reportThis commit of basecamp, built as both the dev app and the portable bundle and driven through its Modules view to inspect the installed UI plugins and loaded core modules — rendered alongside the commands/actions actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MCP integration test covering app launch from the sidebar into a workspace dock.
Changes:
- Locates and launches Fixture A.
- Verifies dock creation, welcome-page hiding, and fixture rendering.
- Adds reusable fixture and object-name helpers.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
romanzac
marked this pull request as ready for review
August 27, 2026 03:47
Khushboo-dev-cpp
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
workspace: opening an app replaces the welcome page with a dockMCP test.Test plan
nix build .#appsucceedsnix build .#smoke-test -Lpassesnix build .#integration-test -Lpasses (if UI-visible)nix build .#doctests -Lif touched)Checklist
fix/,feat/,chore/,docs/,test/, orci/CLAUDE.md/README.md/docs/updated if behaviour or build steps changed.DS_Storefiles removed