Test/MCP UI workspace closing the last dock brings the welcome page back - #345
Open
romanzac wants to merge 2 commits into
Open
Test/MCP UI workspace closing the last dock brings the welcome page back#345romanzac wants to merge 2 commits into
romanzac wants to merge 2 commits into
Conversation
Collaborator
Jenkins Builds
|
8 tasks
unloadUiModuleImpl removed the widget and module/app map entries but never touched m_currentVisibleApp, so after closing the last dock the welcome page returned while backend.currentVisibleApp still named the unloaded app. WorkspaceArea::activeAppChanged only fires from QTabBar::currentChanged, which does not fire when the last dock is removed, so nothing else reset it. Mirror the guarded clear-and-emit already done in the uninstall-cascade path (teardownUiPluginWidget).
Spec MCP-TEST-PLAN v2 §2.A A4: from the A3 state, close fixture A's
dock and gate on dockCount reaching 0 within 5s, the welcome page
becoming visible again with the "Welcome back" greeting (fixture A
stays installed, only unloaded), and backend.currentVisibleApp
returning to "".
The dock is closed via the inspector's evaluate path
(closeDock("test_qml_only") on the WorkspaceArea object) rather than
callMethod, which does not marshal the QString argument correctly.
The test establishes its own precondition — if no dock is open it
re-opens fixture A first, and skips (per spec §0.A) when the fixture
is absent outside --ci mode.
romanzac
force-pushed
the
test/mcp-ui-a4
branch
from
August 27, 2026 04:08
2adb8e6 to
fe4512c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MCP integration coverage for restoring the welcome page after closing the final workspace dock and fixes visible-app state cleanup during unload.
Changes:
- Adds an end-to-end final-dock closure test.
- Clears
currentVisibleAppwhen its module unloads. - Verifies dock removal, welcome-page visibility, greeting, and backend state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/ui-tests.mjs |
Tests the complete final-dock closure flow. |
app/UIPluginManager.cpp |
Clears stale visible-app state during unload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
romanzac
marked this pull request as ready for review
August 27, 2026 05:41
Khushboo-dev-cpp
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
workspace: closing the last dock brings the welcome page backMCP test.Test plan
nix build .#appsucceedsnix build .#smoke-test -Lpassesnix build .#integration-test -Lpasses (if UI-visible)nix build .#doctests -Lif touched)Checklist
fix/,feat/,chore/,docs/,test/, orci/CLAUDE.md/README.md/docs/updated if behaviour or build steps changed.DS_Storefiles removed