Test/MCP UI workspace re-clicking an open app does not create a second dock - #346
Open
romanzac wants to merge 3 commits into
Open
Test/MCP UI workspace re-clicking an open app does not create a second dock#346romanzac wants to merge 3 commits into
romanzac wants to merge 3 commits into
Conversation
Collaborator
Jenkins BuildsClick to see older builds (3)
|
8 tasks
romanzac
force-pushed
the
test/mcp-ui-a4
branch
from
August 27, 2026 04:08
2adb8e6 to
fe4512c
Compare
Spec MCP-TEST-PLAN v2 §2.A A4: from the A3 state, close fixture A's
dock and gate on dockCount reaching 0 within 5s, the welcome page
becoming visible again with the "Welcome back" greeting (fixture A
stays installed, only unloaded), and backend.currentVisibleApp
returning to "".
The dock is closed via the inspector's evaluate path
(closeDock("test_qml_only") on the WorkspaceArea object) rather than
callMethod, which does not marshal the QString argument correctly.
The test establishes its own precondition — if no dock is open it
re-opens fixture A first, and skips (per spec §0.A) when the fixture
is absent outside --ci mode.
Spec MCP-TEST-PLAN v2 §2.A A5: click sidebar.app.test_qml_only twice, 500 ms apart, starting from the empty workspace A4 leaves behind. Gates: WorkspaceArea.dockCount stays 1 across a 2 s settle window after the re-click, backend.currentVisibleApp still reports test_qml_only, and exactly one instantiation of fixture A's root document exists — counted as one QQuickWidget sourced from the fixture's Main.qml plus one render of its unique payload text, since the literal root type is a plain Rectangle the shell instantiates everywhere. The test closes the dock at the end to restore the no-docks baseline for the rest of the suite.
romanzac
force-pushed
the
test/mcp-ui-a5
branch
from
August 27, 2026 05:25
00a952d to
7ec1b6c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MCP UI coverage ensuring re-clicking an open app does not create a duplicate dock.
Changes:
- Adds dock, host, payload, and active-app assertions.
- Adds timing and cleanup logic.
- Accidentally duplicates the existing A4 test.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
romanzac
marked this pull request as ready for review
August 27, 2026 06:40
Khushboo-dev-cpp
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
workspace: re-clicking an open app does not create a second dockMCP test.Test plan
nix build .#appsucceedsnix build .#smoke-test -Lpassesnix build .#integration-test -Lpasses (if UI-visible)nix build .#doctests -Lif touched)Checklist
fix/,feat/,chore/,docs/,test/, orci/CLAUDE.md/README.md/docs/updated if behaviour or build steps changed.DS_Storefiles removed