Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsclient + Node client #291

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Jsclient + Node client #291

wants to merge 2 commits into from

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented May 29, 2020 •
edited by robertodauria
Loading

Converting the js client to one with a cleaner interface that also works with node.js

This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1303

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 80.0%
Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 72.32%
ndt7/upload/sender/sender.go 5 67.65%
Totals Coverage Status
Change from base Build 1299: 0.03%
Covered Lines: 1656
Relevant Lines: 2070
💛 - Coveralls

@mkwiatkowskisoldevelo mkwiatkowskisoldevelo mentioned this pull request Aug 2, 2022
Merged
@SaiedKazemi SaiedKazemi changed the base branch from master to main August 10, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pboothe @coveralls