bumping sharp version to 0.28.3 to support arm64 on macOS#151
Open
benjibee wants to merge 1 commit intomahnunchik:masterfrom
Open
bumping sharp version to 0.28.3 to support arm64 on macOS#151benjibee wants to merge 1 commit intomahnunchik:masterfrom
benjibee wants to merge 1 commit intomahnunchik:masterfrom
Conversation
|
This also fixes #149 |
wszydlak
suggested changes
Jul 8, 2021
wszydlak
left a comment
wszydlak
left a comment
There was a problem hiding this comment.
It looks that sharp api changed a lot, this PR needs more changes. It would be cool to write more tests to be sure gulp-responsive is compatible with sharp api. There needs to be done more changes.
Author
|
That makes sense but I'm not enough into this project at the moment to write those tests. I'm currently using it to create webp, png, and jpeg images in various sizes with renaming, etc. and it's so far without any errors though I understand that's not the same as test coverage ;) |
|
i have problems with node14. can we please push forward the upgrade to 0.28.3? cheers |
|
i also want it to use with node >= 14 |
Author
|
@mahnunchik could this PR just be merged so your plugin keeps on working? Please 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150 by upgrading sharp to a version that support arm64 on macOS