feat: logger interface added #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
ea97f5e to
532c8bd
Compare
Pratham-Mishra04
changed the base branch from
feature/03-21-base_structure_fixes
to
graphite-base/10
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
532c8bd to
ab539a1
Compare
Pratham-Mishra04
changed the base branch from
graphite-base/10
to
03-31-feat_image_inputs_added
Pratham-Mishra04
force-pushed
the
03-31-feat_image_inputs_added
branch
from
8311c51 to
c7d53f9
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
ab539a1 to
c60da1e
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
c60da1e to
dfd98e6
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_image_inputs_added
branch
from
c7d53f9 to
6f05288
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
dfd98e6 to
a187eb8
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_image_inputs_added
branch
2 times, most recently
from
a48ced4 to
87d2329
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
a187eb8 to
37a6f86
Compare
This was referenced Apr 6, 2025
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
37a6f86 to
bb49554
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_image_inputs_added
branch
from
87d2329 to
9af5eb5
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
bb49554 to
51ff3e1
Compare
danpiths
reviewed
Apr 7, 2025
bifrost.go
Outdated
| } | ||
|
|
||
| if logger == nil { | ||
| logger = NewDefaultLogger(interfaces.LogLevelInfo) |
Collaborator
There was a problem hiding this comment.
how do i change this log level for the default logger while initializing bifrost?
Collaborator
Author
There was a problem hiding this comment.
bifrost init takes only logger interface, so if wanna change the log level of the default logger, just pass bifrost.DefaultLogger{level:Info} to the logger interface in Bifrost Init. if nil is passed then it creates a default logger with info level
Collaborator
There was a problem hiding this comment.
haa but they need to know that they can utilize something called as a default logger, add it to the doc comments
Pratham-Mishra04
changed the title
Pratham-Mishra04
changed the title
Closed
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
2 times, most recently
from
25b5061 to
8b08515
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
8b08515 to
12ae714
Compare
danpiths
force-pushed
the
03-31-feat_logger_interface_added
branch
from
12ae714 to
dcc4572
Compare
danpiths
force-pushed
the
03-31-feat_image_inputs_added
branch
from
9af5eb5 to
9493e3f
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_image_inputs_added
branch
from
9493e3f to
9af5eb5
Compare
Pratham-Mishra04
force-pushed
the
03-31-feat_logger_interface_added
branch
from
dcc4572 to
12ae714
Compare
This was referenced Apr 10, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.