fix(payment-stripe): Prevent the Stripe payment provider to delete Stripe customers - FIXES #13667

[adevinwild]

Summary

What — What changes are introduced in this PR?

The deleteAccountHolder method has been modified to make sure we never remove permanently customers for the Stripe provider, as it is undoable and will causes a lot of issues for customers in case that method is triggered.

Why — Why are these changes relevant or necessary?

At the time of writing this PR, the current logic triggers the Stripe SDK to permanently delete a customer, thus preventing checkout and trapping the customer in a loop that cannot be escaped in case of a payment session error

How — How have these changes been implemented?
We just return an empty object for the deleteAccountHolder abstract fn on the Stripe payment provider.

Testing — How have these changes been tested, or how can the reviewer test the feature?

• Try to create a $0 payment collection with Stripe
• Stripe will throw an error while trying to create a payment session since it cannot charge $0
• The failure of the workflow will trigger the compensate fn of all the failed steps of the createPaymentSessionWorkflow
• createAccountHolderStep will try to use the deleteAccountHolder fn from the service
• This will no longer triggers a permanent deletion of the customer

---

Examples

Check the Testing section above

---

Checklist

Please ensure the following before requesting a review:

• I have added a changeset for this PR
  • Every non-breaking change should be marked as a patch
  • To add a changeset, run yarn changeset and follow the prompts
• The changes are covered by relevant tests
• I have verified the code works as intended locally
• I have linked the related issue(s) if applicable

---

Additional Context

Related to :
#13667

It's a bit radical, but I'm open to update this in case there's a better solution 🙌

---

Note

Stops permanently deleting Stripe customers by changing deleteAccountHolder to return an empty result instead of calling Stripe’s delete API.

• Stripe payment provider:
  • Update packages/modules/providers/payment-stripe/src/core/stripe-base.ts: make deleteAccountHolder a no-op (returns {}) and remove call to stripe.customers.del.
• Changeset:
  • Add patch note for @medusajs/payment-stripe describing the change to deleteAccountHolder.

^{Written by Cursor Bugbot for commit f190bec. This will update automatically on new commits. Configure here.}

[changeset-bot]

🦋 Changeset detected

Latest commit: f190bec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages

Name	Type
@medusajs/payment-stripe	Patch
@medusajs/medusa	Patch
@medusajs/test-utils	Patch
@medusajs/medusa-oas-cli	Patch
integration-tests-http	Patch
@medusajs/analytics	Patch
@medusajs/api-key	Patch
@medusajs/auth	Patch
@medusajs/caching	Patch
@medusajs/cart	Patch
@medusajs/currency	Patch
@medusajs/customer	Patch
@medusajs/file	Patch
@medusajs/fulfillment	Patch
@medusajs/index	Patch
@medusajs/inventory	Patch
@medusajs/link-modules	Patch
@medusajs/locking	Patch
@medusajs/notification	Patch
@medusajs/order	Patch
@medusajs/payment	Patch
@medusajs/pricing	Patch
@medusajs/product	Patch
@medusajs/promotion	Patch
@medusajs/region	Patch
@medusajs/sales-channel	Patch
@medusajs/settings	Patch
@medusajs/stock-location	Patch
@medusajs/store	Patch
@medusajs/tax	Patch
@medusajs/user	Patch
@medusajs/workflow-engine-inmemory	Patch
@medusajs/workflow-engine-redis	Patch
@medusajs/draft-order	Patch
@medusajs/oas-github-ci	Patch
@medusajs/cache-inmemory	Patch
@medusajs/cache-redis	Patch
@medusajs/event-bus-local	Patch
@medusajs/event-bus-redis	Patch
@medusajs/analytics-local	Patch
@medusajs/analytics-posthog	Patch
@medusajs/auth-emailpass	Patch
@medusajs/auth-github	Patch
@medusajs/auth-google	Patch
@medusajs/caching-redis	Patch
@medusajs/file-local	Patch
@medusajs/file-s3	Patch
@medusajs/fulfillment-manual	Patch
@medusajs/locking-postgres	Patch
@medusajs/locking-redis	Patch
@medusajs/notification-local	Patch
@medusajs/notification-sendgrid	Patch
@medusajs/core-flows	Patch
@medusajs/framework	Patch
@medusajs/js-sdk	Patch
@medusajs/modules-sdk	Patch
@medusajs/orchestration	Patch
@medusajs/types	Patch
@medusajs/utils	Patch
@medusajs/workflows-sdk	Patch
@medusajs/cli	Patch
@medusajs/deps	Patch
@medusajs/telemetry	Patch
@medusajs/admin-bundler	Patch
@medusajs/admin-sdk	Patch
@medusajs/admin-shared	Patch
@medusajs/admin-vite-plugin	Patch
@medusajs/dashboard	Patch
@medusajs/icons	Patch
@medusajs/toolbox	Patch
@medusajs/ui-preset	Patch
create-medusa-app	Patch
medusa-dev-cli	Patch
@medusajs/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@adevinwild is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.