Skip to content

fix(payment-stripe): Prevent the Stripe payment provider to delete Stripe customers - FIXES #13667 #14112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(payment-stripe): Prevent the Stripe payment provider to delete Stripe customers - FIXES #13667 #14112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ffba1
refactor(payment-stripe): update deleteAccountHolder method to preven…
adevinwild Nov 24, 2025
f190bec
chore: version bump
adevinwild Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/common-walls-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/payment-stripe": patch
---

Modify the `deleteAccountHolder` implementation for the Stripe payment provider to prevent the permanent deletion of the underlying Stripe customer.
21 changes: 3 additions & 18 deletions packages/modules/providers/payment-stripe/src/core/stripe-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,24 +525,9 @@ abstract class StripeBase extends AbstractPaymentProvider<StripeOptions> {
}
}

async deleteAccountHolder({
context,
}: DeleteAccountHolderInput): Promise<DeleteAccountHolderOutput> {
const { account_holder } = context
const accountHolderId = account_holder?.data?.id as string | undefined
if (!accountHolderId) {
throw this.buildError(
"No account holder in context",
new Error("No account holder provided while deleting account holder")
)
}

try {
await this.stripe_.customers.del(accountHolderId)
return {}
} catch (e) {
throw this.buildError("An error occurred in deleteAccountHolder", e)
}
async deleteAccountHolder(_: DeleteAccountHolderInput): Promise<DeleteAccountHolderOutput> {
// We cannot delete an account from Stripe as it is a permanent operation.
return {}
}

async listPaymentMethods({
Expand Down