[Fixed] Wait until worker shutdown is complete #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
When shutting down workers, ensure proper termination by waiting until the future is complete (with
future.result()).This should fix a spammy error we're getting on each shutdown:
This started happening in
google-cloud-pubsub==2.31.0(changelog), most probably due to the inclusion of this fix.🤔 Why?
.result()is expected to be called after.cancel()when shutting down, according to the documentation.We're already following this approach when safely bootstrapping subscription consumers.
🔗 Related issue
N/A