MACRO cleanup #434
Open
MACRO cleanup #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ripplebiz should I keep resolving the conflicts with |
|
I'm not really a fan of PR's like this, as the merge conflicts go both ways, and I prefer that the various 'champions' of the variants, do refactors of the variants they are actively working on. There is currently a fairly big push to try to get sensor/GPS/UI parity among all the variants, and that needs to take precedence. |
|
OK np, just to understand the effort as this was mainly housekeeping removing dupe flags. It could also be possible to reduce scope for this PR, just keep the central part at |
This reverts commit c88b50c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
cleans up the variants folder andmoves duplicated MACRO flags to thearduino_baseconfiguration. It also adds (disabled by default) more of the available debug flags.