Skip to content

Move test_mast_compat.py to tests/fb/ for internal-only tests#358

Closed
FindHao wants to merge 2 commits intomainfrom
export-D96222276
Closed

Move test_mast_compat.py to tests/fb/ for internal-only tests#358
FindHao wants to merge 2 commits intomainfrom
export-D96222276

Conversation

@FindHao
Copy link
Member

@FindHao FindHao commented Mar 12, 2026

Summary:
Move test_mast_compat.py from tests/cpu/ to tests/fb/ because it imports
from tritonparse.fb.utils which is an internal-only module not available
in OSS. This fixes the ModuleNotFoundError in OSS CI:
ModuleNotFoundError: No module named 'tritonparse.fb'

Differential Revision: D96222276

Yueming Hao and others added 2 commits March 11, 2026 12:09
Summary:
- Update all GitHub Actions to latest major versions to resolve Node.js 20 deprecation warnings:
  - actions/checkout: v4 → v6
  - actions/setup-python: v4/v5 → v6
  - actions/setup-node: v4 → v6
  - actions/cache: v3 → v5
  - actions/configure-pages: v4 → v5
  - actions/upload-pages-artifact: v3 → v4
- Update Python version from 3.11 to 3.13 across all CI workflows and scripts

Affected files:
- .github/workflows/nightly-pypi.yml
- .github/workflows/test.yml
- .github/workflows/deploy-pages.yml
- .github/workflows/deploy-pages-standalone.yml
- .github/workflows/website-build.yml
- .ci/setup.sh

Differential Revision: D96172761
Summary:
Move test_mast_compat.py from tests/cpu/ to tests/fb/ because it imports
from tritonparse.fb.utils which is an internal-only module not available
in OSS. This fixes the ModuleNotFoundError in OSS CI:
  ModuleNotFoundError: No module named 'tritonparse.fb'

Differential Revision: D96222276
Copilot AI review requested due to automatic review settings March 12, 2026 00:03
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 12, 2026
@meta-codesync
Copy link

meta-codesync bot commented Mar 12, 2026

@FindHao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96222276.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix OSS CI failures caused by an internal-only tritonparse.fb import in the MAST compatibility tests, by relocating those tests out of the OSS test suite.

Changes:

  • Removed tests/cpu/test_mast_compat.py, which unconditionally imports tritonparse.fb.utils.
  • Updated multiple GitHub Actions workflows to use newer major versions of actions/* and bumped CI Python from 3.11 to 3.13.
  • Updated .ci/setup.sh default PYTHON_VERSION to 3.13.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/cpu/test_mast_compat.py Removes internal-only MAST compatibility tests that import tritonparse.fb
.github/workflows/test.yml Updates action versions, Python version, and cache keys for CI test workflows
.github/workflows/nightly-pypi.yml Updates action versions and Python version for nightly publishing
.github/workflows/website-build.yml Updates action versions for website build checks
.github/workflows/deploy-pages.yml Updates action versions for GitHub Pages deploy
.github/workflows/deploy-pages-standalone.yml Updates action versions for standalone Pages deploy
.ci/setup.sh Changes default CI Python version from 3.11 to 3.13

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description/title say test_mast_compat.py was moved to tests/fb/, but in this branch the file is deleted and there is no tests/fb/ directory. If the intent is to keep these internal-only tests, add them under tests/fb/ and ensure OSS test runs skip/ignore that directory (e.g., skipUnless(is_fbcode())). Otherwise, update the PR metadata to reflect that the tests are being removed from OSS entirely.

Copilot uses AI. Check for mistakes.
@meta-codesync
Copy link

meta-codesync bot commented Mar 13, 2026

This pull request has been merged in 04ea4d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants