Skip to content

Move test_mast_compat.py to tests/fb/ for internal-only tests #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FindHao wants to merge 2 commits into from
Closed

Move test_mast_compat.py to tests/fb/ for internal-only tests #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbdb8a7
Update GitHub Actions to latest versions and Python 3.11 to 3.13
Mar 11, 2026
7373114
Move test_mast_compat.py to tests/fb/ for internal-only tests
FindHao Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -e

# Default values
CONDA_ENV=${CONDA_ENV:-"tritonparse"}
PYTHON_VERSION=${PYTHON_VERSION:-"3.11"}
PYTHON_VERSION=${PYTHON_VERSION:-"3.13"}
CUDA_VERSION=${CUDA_VERSION:-"12.8"}

echo "Setting up tritonparse environment..."
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deploy-pages-standalone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: "22"
cache: "npm"
Expand All @@ -47,10 +47,10 @@ jobs:
cp website/dist/standalone.html standalone-deploy/index.html

- name: Setup Pages
uses: actions/configure-pages@v4
uses: actions/configure-pages@v5

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v4
with:
path: "./standalone-deploy"

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deploy-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: "22"
cache: "npm"
Expand All @@ -50,10 +50,10 @@ jobs:
run: npm run build

- name: Setup Pages
uses: actions/configure-pages@v4
uses: actions/configure-pages@v5

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v4
with:
path: "./website/dist"

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0 # setuptools-scm requires full history/tags

- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: "3.11"
python-version: "3.13"

- name: Check for new commits since last nightly
id: check
Expand Down
42 changes: 21 additions & 21 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description/title say test_mast_compat.py was moved to tests/fb/, but in this branch the file is deleted and there is no tests/fb/ directory. If the intent is to keep these internal-only tests, add them under tests/fb/ and ensure OSS test runs skip/ignore that directory (e.g., skipUnless(is_fbcode())). Otherwise, update the PR metadata to reflect that the tests are being removed from OSS entirely.

Copilot uses AI. Check for mistakes.

- name: Set up Python 3.11
uses: actions/setup-python@v4
- name: Set up Python 3.13
uses: actions/setup-python@v6
with:
python-version: "3.11"
python-version: "3.13"

- name: Install development dependencies
run: |
Expand All @@ -58,12 +58,12 @@ jobs:
runs-on: 4-core-ubuntu-gpu-t4
timeout-minutes: 120
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Set up Python 3.11
uses: actions/setup-python@v4
- name: Set up Python 3.13
uses: actions/setup-python@v6
with:
python-version: "3.11"
python-version: "3.13"

- name: Get daily cache timestamp
id: daily-cache
Expand All @@ -82,12 +82,12 @@ jobs:
echo "Using weekly cache stamp: $WEEK_STAMP"

- name: Cache pip dependencies
uses: actions/cache@v3
uses: actions/cache@v5
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-3.11-${{ steps.daily-cache.outputs.date }}
key: ${{ runner.os }}-pip-3.13-${{ steps.daily-cache.outputs.date }}
restore-keys: |
${{ runner.os }}-pip-3.11-
${{ runner.os }}-pip-3.13-

- name: Get Triton latest commit
id: triton-commit
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
fi

- name: Cache Triton source and build
uses: actions/cache@v3
uses: actions/cache@v5
with:
path: |
/tmp/triton
Expand All @@ -129,7 +129,7 @@ jobs:
- name: Setup environment
env:
CONDA_ENV: tritonparse
PYTHON_VERSION: "3.11"
PYTHON_VERSION: "3.13"
CUDA_VERSION: "12.8"
run: |
bash .ci/setup.sh
Expand Down Expand Up @@ -159,12 +159,12 @@ jobs:
runs-on: 4-core-ubuntu-gpu-t4
timeout-minutes: 120
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Set up Python 3.11
uses: actions/setup-python@v4
- name: Set up Python 3.13
uses: actions/setup-python@v6
with:
python-version: "3.11"
python-version: "3.13"

- name: Get daily cache timestamp
id: daily-cache
Expand All @@ -175,17 +175,17 @@ jobs:
echo "Using daily cache stamp: $DATE_STAMP"

- name: Cache pip dependencies
uses: actions/cache@v3
uses: actions/cache@v5
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-3.11-${{ steps.daily-cache.outputs.date }}
key: ${{ runner.os }}-pip-3.13-${{ steps.daily-cache.outputs.date }}
restore-keys: |
${{ runner.os }}-pip-3.11-
${{ runner.os }}-pip-3.13-

- name: Setup environment
env:
CONDA_ENV: tritonparse-pip
PYTHON_VERSION: "3.11"
PYTHON_VERSION: "3.13"
CUDA_VERSION: "12.8"
run: |
bash .ci/setup.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/website-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: "24"
cache: "npm"
Expand Down
138 changes: 0 additions & 138 deletions tests/cpu/test_mast_compat.py
View file
Open in desktop

This file was deleted.

Loading