-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support generic Uint8Array<ArrayBuffer>
#1944
base: main
Are you sure you want to change the base?
Conversation
02eb871
to
f203df7
Compare
This should use ArrayBuffer by default than just overriding some cases, and use SAB+AB when |
@sandersn: The implementation changed significantly. Can you take another look? |
|
There are still package.json entries for Unfortunately, 5.6 cannot be folded into 5.7+ as use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. One question about the change to WritableStream in overridingtypes.json to make sure I understood it correctly.
}, | ||
"writable": { | ||
"name": "writable", | ||
"readonly": true, | ||
"overrideType": "WritableStream<string>" | ||
"type": "WritableStream", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output doesn't change that I could tell, so I guess this is an update to use the new subtype property for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refraining from overrideType is a good change 👍🏻 (use of overrideType disables type dependency tracking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Though I would have preferred if this kind of change is file as a separate PR, as mixing it makes harder to understand it)
}, | ||
"writable": { | ||
"name": "writable", | ||
"readonly": true, | ||
"overrideType": "WritableStream<string>" | ||
"type": "WritableStream", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Though I would have preferred if this kind of change is file as a separate PR, as mixing it makes harder to understand it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still would like to change gitattributes to use only LF, looks good otherwise!
This updates the DOM to use
Uint8Array<ArrayBuffer>
in some cases where the specification expects it. This addresses an error reported in microsoft/TypeScript#61432 forajayyy/SponsorBlock
.This now also fixes
AllowSharedBufferSource
, which fails to includeSharedArrayBuffer
.Fixes microsoft/TypeScript#61480