fix: Unexpected Safari-specific event init options #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Apr 2, 2025
inputfiles/removedTypes.jsonc
Outdated
| "FetchEventInit": { | ||
| "members": { | ||
| "member": { | ||
| "replacesClientId": null // Removed from all browsers |
There was a problem hiding this comment.
Not sure it's removed or simply not implemented. Unless there's clues let's say not implemented. And please write the confirmed date as things change.
inputfiles/removedTypes.jsonc
Outdated
| } | ||
| } | ||
| }, | ||
| "FetchEventInit": { |
There was a problem hiding this comment.
This file tries to make things alphabetically ordered, please move this above. Same for the event init.
|
Done @saschanaz |
saschanaz
reviewed
Apr 2, 2025
inputfiles/removedTypes.jsonc
Outdated
| "FetchEventInit": { | ||
| "members": { | ||
| "member": { | ||
| "replacesClientId": null // Not implemented |
There was a problem hiding this comment.
Can you add dates as line 355 does for example? Same below.
|
Hello @saschanaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1689