Skip to content

fix: Unexpected Safari-specific event init options #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 6 commits into from
Apr 15, 2025
Merged

fix: Unexpected Safari-specific event init options #1964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1635840
chore: remove url for RTCPeerConnectionIceEventInit
Bashamega Apr 2, 2025
1593c27
chore: remove replacesClientId from FetchEventInit
Bashamega Apr 2, 2025
869ea88
change comment
Bashamega Apr 2, 2025
164e9e9
chore: organize
Bashamega Apr 2, 2025
1af210f
generate dates
Bashamega Apr 2, 2025
3df0bfd
Update inputfiles/removedTypes.jsonc
Bashamega Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,6 @@ interface RTCPeerConnectionIceErrorEventInit extends EventInit {

interface RTCPeerConnectionIceEventInit extends EventInit {
candidate?: RTCIceCandidate | null;
url?: string | null;
}

interface RTCReceivedRtpStreamStats extends RTCRtpStreamStats {
Expand Down
1 change: 0 additions & 1 deletion baselines/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ interface FetchEventInit extends ExtendableEventInit {
clientId?: string;
handled?: Promise<void>;
preloadResponse?: Promise<any>;
replacesClientId?: string;
request: Request;
resultingClientId?: string;
}
Expand Down
1 change: 0 additions & 1 deletion baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,6 @@ interface RTCPeerConnectionIceErrorEventInit extends EventInit {

interface RTCPeerConnectionIceEventInit extends EventInit {
candidate?: RTCIceCandidate | null;
url?: string | null;
}

interface RTCReceivedRtpStreamStats extends RTCRtpStreamStats {
Expand Down
1 change: 0 additions & 1 deletion baselines/ts5.5/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ interface FetchEventInit extends ExtendableEventInit {
clientId?: string;
handled?: Promise<void>;
preloadResponse?: Promise<any>;
replacesClientId?: string;
request: Request;
resultingClientId?: string;
}
Expand Down
1 change: 0 additions & 1 deletion baselines/ts5.5/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ interface FetchEventInit extends ExtendableEventInit {
clientId?: string;
handled?: Promise<void>;
preloadResponse?: Promise<any>;
replacesClientId?: string;
request: Request;
resultingClientId?: string;
}
Expand Down
1 change: 0 additions & 1 deletion baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ interface FetchEventInit extends ExtendableEventInit {
clientId?: string;
handled?: Promise<void>;
preloadResponse?: Promise<any>;
replacesClientId?: string;
request: Request;
resultingClientId?: string;
}
Expand Down
14 changes: 14 additions & 0 deletions inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,20 @@
}
}
},
"RTCPeerConnectionIceEventInit": {
"members": {
"member": {
"url": null // Safari +12 only
}
}
},
"FetchEventInit": {
Copy link
Collaborator

@saschanaz saschanaz Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file tries to make things alphabetically ordered, please move this above. Same for the event init.

"members": {
"member": {
"replacesClientId": null // Removed from all browsers
Copy link
Collaborator

@saschanaz saschanaz Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's removed or simply not implemented. Unless there's clues let's say not implemented. And please write the confirmed date as things change.

}
}
},
"RTCEncodedAudioFrameMetadata": {
"members": {
"member": {
Expand Down
Loading