Add Aspire 13.4 breaking-changes reference - #25
Draft
David Fowler (davidfowl) with Copilot wants to merge 4 commits into
Draft
Add Aspire 13.4 breaking-changes reference#25David Fowler (davidfowl) with Copilot wants to merge 4 commits into
David Fowler (davidfowl) with Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix missing 13.4 breaking changes references in Aspire skills
Generalize Aspire breaking-changes reference to be version-independent
Jun 2, 2026
Member
Triage note for reviewer — design call worth confirmingThis PR goes beyond the literal ask in #24 (which reported the missing 13.4 breaking-changes content): it deletes the inline 13.3 scrub list and replaces it with a single link-only pointer page. Worth a deliberate decision before merge: Trade-off
Options
Calling it out because option 1 loses real value the original file was providing (a flat, scannable list of identifiers an agent can match against without a network round-trip). The right call depends on how the skill bundle is consumed — happy to defer. |
Restore the 13.3 scrub list, add the 13.4 per-version scrub list, and keep the generic breaking-changes page as an index to local and upstream references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
David Pine (IEvangelist)
force-pushed
the
copilot/fix-aspire-13-4-breaking-changes
branch
from
June 9, 2026 19:42
21e8aaf to
6a02859
Compare
Configure Vally eval discovery to scan the skills directory so suite runs find skills/*/evals/eval.yaml instead of only the shared eval fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Changes
skills/aspire/references/aspire-13-4-breaking-changes.mdas a local, agent-facing scrub list for Aspire 13.4 breaking changes.aspire-breaking-changes.mdas a version index that points to local scrub files first, then upstream release notes for gaps.skills/aspire/SKILL.mdreferences and the packaged plugin mirror pointer files.paths.evals: skills, sovally eval --suite ci-gatediscoversskills/*/evals/eval.yamlinstead of scanning only shared fixture files underevals/.Validation
scannedCount: 6,matched: 6,errors: 0vally lint skillsvally lint --eval-spec skills/<skill>/evals/eval.yamlfor all six skill specsnpm run bundleNote: after rebasing onto current
main, this repo no longer has annpm run buildscript;bundleis the remaining package validation script.