Skip to content

Add Aspire 13.4 breaking-changes reference - #25

Draft
David Fowler (davidfowl) with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-aspire-13-4-breaking-changes
Draft

Add Aspire 13.4 breaking-changes reference#25
David Fowler (davidfowl) with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-aspire-13-4-breaking-changes

Conversation

Copilot AI commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #24.

Changes

  • Adds skills/aspire/references/aspire-13-4-breaking-changes.md as a local, agent-facing scrub list for Aspire 13.4 breaking changes.
  • Keeps the existing 13.3 scrub list intact and reframes aspire-breaking-changes.md as a version index that points to local scrub files first, then upstream release notes for gaps.
  • Updates skills/aspire/SKILL.md references and the packaged plugin mirror pointer files.
  • Updates the PR-review checklist to point reviewers at the version index and pinned scrub files.
  • Fixes Vally suite discovery by setting paths.evals: skills, so vally eval --suite ci-gate discovers skills/*/evals/eval.yaml instead of scanning only shared fixture files under evals/.

Validation

  • Vally discovery smoke check: scannedCount: 6, matched: 6, errors: 0
  • vally lint skills
  • vally lint --eval-spec skills/<skill>/evals/eval.yaml for all six skill specs
  • npm run bundle

Note: after rebasing onto current main, this repo no longer has an npm run build script; bundle is the remaining package validation script.

Copilot AI linked an issue Jun 2, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix missing 13.4 breaking changes references in Aspire skills Generalize Aspire breaking-changes reference to be version-independent Jun 2, 2026
@IEvangelist

Copy link
Copy Markdown
Member

Triage note for reviewer — design call worth confirming

This PR goes beyond the literal ask in #24 (which reported the missing 13.4 breaking-changes content): it deletes the inline 13.3 scrub list and replaces it with a single link-only pointer page. Worth a deliberate decision before merge:

Trade-off

Link-only (this PR) Inline per-version (status quo + add 13.4)
Stays current ✅ Always ❌ Goes stale each release; needs a PR per version
Agent-grep-able patterns (NameOutput → NameOutputReference, --log-level → --pipeline-log-level, withEnvironment* deprecations, etc.) ❌ Lost ✅ Local, no fetch
Works offline / inside bundle snapshot ❌ Requires WebFetch/curl ✅ Self-contained
Maintenance cost Low Moderate (one file per release)

Options

  1. Merge as-is — accept the loss of the inline scrub table in exchange for never going stale.
  2. Hybrid — keep both: add aspire-13-4-breaking-changes.md (mirroring the existing 13.3 file format), keep aspire-13-3-breaking-changes.md, and add the version-independent pointer this PR introduces as a third reference for "anything past the latest pinned file."
  3. Restore 13.3 + add 13.4 inline — straight literal fix to the aspire skills doesn't include 13.4 breaking changes references #24, no link-only page.

Calling it out because option 1 loses real value the original file was providing (a flat, scannable list of identifiers an agent can match against without a network round-trip). The right call depends on how the skill bundle is consumed — happy to defer.

cc David Pine (@IEvangelist)

Copilot AI and others added 3 commits June 9, 2026 14:40
Restore the 13.3 scrub list, add the 13.4 per-version scrub list, and keep the generic breaking-changes page as an index to local and upstream references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@IEvangelist
David Pine (IEvangelist) force-pushed the copilot/fix-aspire-13-4-breaking-changes branch from 21e8aaf to 6a02859 Compare June 9, 2026 19:42
@IEvangelist David Pine (IEvangelist) changed the title Generalize Aspire breaking-changes reference to be version-independent Add Aspire 13.4 breaking-changes reference Jun 9, 2026
Configure Vally eval discovery to scan the skills directory so suite runs find skills/*/evals/eval.yaml instead of only the shared eval fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the aspire skills doesn't include 13.4 breaking changes references

3 participants