Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

Enables dump tests on macOS that were previously skipped due to createdump not working correctly on the apphost.

Fixes #4800

Applied the same workaround pattern used in HangDumpProcessTreeTests via DumpWorkaround.GetGlobalPropertiesWorkaround():

  • HangDumpOutputTests.cs: Removed OSCondition, added UseAppHost conditional
  • HangDumpTests.cs: Removed OSCondition from 5 test methods, added UseAppHost conditional
  • RetryFailedTestsTests.cs: Removed OSCondition from RetryFailedTests_MoveFiles_Succeeds, added UseAppHost conditional
  • TrxTests.cs: Removed OSCondition from Trx_WhenTestHostCrash_ErrorIsDisplayedInsideTheTrx, added UseAppHost conditional

The fix conditionally disables apphost on macOS in test asset project files:

<!-- Before -->
<UseAppHost>true</UseAppHost>

<!-- After -->
<UseAppHost Condition="!$([MSBuild]::IsOSPlatform('OSX'))">true</UseAppHost>

Related: dotnet/runtime#119945

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 8xbvsblobprodcus382.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.25575.1.txt (dns block)
    • Triggering command: ./.dotnet/dotnet ./.dotnet/dotnet build test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj --verbosity quiet (dns block)
  • rcxvsblobprodcus328.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet ./.dotnet/dotnet build test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj --verbosity quiet (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Unskip dump tests on macOS</issue_title>
<issue_description>Some tests under test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests, specifically in the following files:

  • HangDumpOutputTests.cs
  • HangDumpTests.cs
  • RetryFailedTestsTests.cs
  • TrxTests.cs

are skipped on macOS. We should unskip these tests and update them similar to HangDump_DumpAllChildProcesses_CreateDump in HangDumpProcessTreeTests using DumpWorkaround.GetGlobalPropertiesWorkaround</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Unskip dump tests for macOS integration Unskip dump tests on macOS Nov 27, 2025
Copilot finished work on behalf of Evangelink November 27, 2025 17:44
Copilot AI requested a review from Evangelink November 27, 2025 17:44
@Evangelink Evangelink marked this pull request as ready for review November 28, 2025 10:00
@Evangelink Evangelink enabled auto-merge (squash) November 28, 2025 12:02
@Evangelink Evangelink merged commit db335de into main Nov 28, 2025
8 checks passed
@Evangelink Evangelink deleted the copilot/unskip-dump-tests-macos branch November 28, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unskip dump tests on macOS

3 participants