Skip to content

Unskip dump tests on macOS #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 28, 2025
+49 −92
Merged

Unskip dump tests on macOS #7007

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7ff09f9
Initial plan
Copilot Nov 27, 2025
2176928
Unskip dump tests on macOS by using UseAppHost conditional
Copilot Nov 27, 2025
bd52ad9
Update test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.In…
Evangelink Nov 28, 2025
2dff9ae
Update test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.In…
Evangelink Nov 28, 2025
f506204
Update test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.In…
Evangelink Nov 28, 2025
1ace6e7
Update test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.In…
Evangelink Nov 28, 2025
eb5cd41
Apply suggestions from code review
Evangelink Nov 28, 2025
0427bd1
Fix tests
Evangelink Nov 28, 2025
2e2a2e6
Apply suggestion from @Evangelink
Evangelink Nov 28, 2025
24f59a3
Force codesign
Evangelink Nov 28, 2025
da4d199
Test
Evangelink Nov 28, 2025
09ffc57
Proper fix
Evangelink Nov 28, 2025
cf4eaac
Stricter condition
Evangelink Nov 28, 2025
2eea0c9
Fix
Youssef1313 Nov 28, 2025
5a160d5
Fix for VSTEst
Youssef1313 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...rationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HangDumpOutputTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public sealed class HangDumpOutputTests : AcceptanceTestBase<HangDumpOutputTests
{
[DataRow("Mini")]
[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_Outputs_HangingTests_EvenWhenHangingTestsHaveTheSameDisplayName(string format)
{
// This test makes sure that when tests have the same display name (e.g. like Test1 from both Class1 and Class2)
Expand Down Expand Up @@ -51,7 +50,7 @@ public sealed class TestAssetFixture() : TestAssetFixtureBase(AcceptanceFixture.
<PropertyGroup>
<TargetFrameworks>$TargetFrameworks$</TargetFrameworks>
<OutputType>Exe</OutputType>
<UseAppHost>true</UseAppHost>
<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>
<Nullable>enable</Nullable>
<LangVersion>preview</LangVersion>
</PropertyGroup>
Expand Down
7 changes: 1 addition & 6 deletions .../IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HangDumpTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public sealed class HangDumpTests : AcceptanceTestBase<HangDumpTests.TestAssetFi
{
[DynamicData(nameof(TargetFrameworks.AllForDynamicData), typeof(TargetFrameworks))]
[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_DefaultSetting_CreateDump(string tfm)
{
string resultDirectory = Path.Combine(AssetFixture.TargetAssetPath, Guid.NewGuid().ToString("N"), tfm);
Expand All @@ -27,7 +26,6 @@ public async Task HangDump_DefaultSetting_CreateDump(string tfm)
}

[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_WithDotnetTest_CreateDump()
{
string resultDirectory = Path.Combine(AssetFixture.TargetAssetPath, Guid.NewGuid().ToString("N"), TargetFrameworks.NetCurrent);
Expand All @@ -51,7 +49,6 @@ public async Task HangDump_WithDotnetTest_CreateDump()
}

[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_CustomFileName_CreateDump()
{
string resultDirectory = Path.Combine(AssetFixture.TargetAssetPath, Guid.NewGuid().ToString("N"), TargetFrameworks.NetCurrent);
Expand All @@ -69,7 +66,6 @@ public async Task HangDump_CustomFileName_CreateDump()
}

[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_PathWithSpaces_CreateDump()
{
string resultDir = Path.Combine(AssetFixture.TargetAssetPath, Guid.NewGuid().ToString("N"), TargetFrameworks.NetCurrent);
Expand All @@ -94,7 +90,6 @@ public async Task HangDump_PathWithSpaces_CreateDump()
[DataRow("Triage")]
[DataRow("Full")]
[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task HangDump_Formats_CreateDump(string format)
{
string resultDirectory = Path.Combine(AssetFixture.TargetAssetPath, Guid.NewGuid().ToString("N"), format);
Expand Down Expand Up @@ -153,7 +148,7 @@ public sealed class TestAssetFixture() : TestAssetFixtureBase(AcceptanceFixture.
<PropertyGroup>
<TargetFrameworks>$TargetFrameworks$</TargetFrameworks>
<OutputType>Exe</OutputType>
<UseAppHost>true</UseAppHost>
<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>
<Nullable>enable</Nullable>
<LangVersion>preview</LangVersion>
</PropertyGroup>
Expand Down
4 changes: 1 addition & 3 deletions ...tionTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/RetryFailedTestsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@ public async Task RetryFailedTests_MaxTestsCount_Succeeds(string tfm, bool fail)
[TestMethod]
// We use crash dump, not supported in NetFramework at the moment
[DynamicData(nameof(TargetFrameworks.NetForDynamicData), typeof(TargetFrameworks))]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX)]
public async Task RetryFailedTests_MoveFiles_Succeeds(string tfm)
// TODO: Crash dump is not working properly on macos, so we skip the test for now
=> await RetryHelper.RetryAsync(
async () =>
{
Expand Down Expand Up @@ -229,7 +227,7 @@ public sealed class TestAssetFixture() : TestAssetFixtureBase(AcceptanceFixture.
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<OutputType>Exe</OutputType>
<UseAppHost>true</UseAppHost>
<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>
<LangVersion>preview</LangVersion>
<GenerateTestingPlatformEntryPoint>false</GenerateTestingPlatformEntryPoint>
<TestingPlatformCaptureOutput>false</TestingPlatformCaptureOutput>
Expand Down
3 changes: 1 addition & 2 deletions test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/TrxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public async Task Trx_WhenReportTrxIsSpecified_TrxReportIsGeneratedInDefaultLoca

[DynamicData(nameof(TargetFrameworks.NetForDynamicData), typeof(TargetFrameworks))]
[TestMethod]
[OSCondition(ConditionMode.Exclude, OperatingSystems.OSX, IgnoreMessage = "Investigate failures on macos")]
public async Task Trx_WhenTestHostCrash_ErrorIsDisplayedInsideTheTrx(string tfm)
{
string fileName = Guid.NewGuid().ToString("N");
Expand Down Expand Up @@ -220,7 +219,7 @@ public sealed class TestAssetFixture() : TestAssetFixtureBase(AcceptanceFixture.
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<OutputType>Exe</OutputType>
<UseAppHost>true</UseAppHost>
<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>
<LangVersion>preview</LangVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Loading