-
Notifications
You must be signed in to change notification settings - Fork 36.4k
Fix issue where local terminal failed to open in remote scenarios #277920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where local terminals failed to open in remote workspace scenarios. The fix explicitly retrieves the local default profile before creating a terminal to ensure the correct local shell is used instead of accidentally using remote shell profiles.
Key Changes:
- Added
ITerminalProfileResolverServiceandOSimports to resolve local terminal profiles - Modified terminal creation to explicitly fetch and apply the local default profile configuration
- Added explanatory comments describing the fix
src/vs/workbench/contrib/terminal/electron-browser/terminalRemote.ts
Outdated
Show resolved
Hide resolved
|
This would prevent the aggressive error message and also prevent immediate close of local terminal, but it won't respect local terminal profile setting. It would just open powershell for windows, regardless of if I had "terminal.integrated.defaultProfile.windows": "Git bash", for local windows settings in wsl scenario. I think we need some way to ensure when terminal is opened, it respects corresponding profile (either remote or local) such as like in #277968 WIP |
|
Some logs: @Tyriar Is Update: changing to Schemas.file makes it work |
Resolves: #148572
This would allow default shell to launch on non-wsl remote/local scenario as well.