Skip to content

Fix issue where local terminal failed to open in remote scenarios #277920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 20, 2025
Merged

Fix issue where local terminal failed to open in remote scenarios #277920

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5aa5ea7
try adding options.remoteAuthority field for profile
anthonykim1 Nov 12, 2025
a11048f
try explicit remoteAuthority undefined when local
anthonykim1 Nov 17, 2025
31bbae2
Dont touch terminalProfileResolverService.ts
anthonykim1 Nov 17, 2025
4f5b582
Better comments to explicitly get local default profile in remote
anthonykim1 Nov 17, 2025
e590c62
Try to handle mac -> linux scenario
anthonykim1 Nov 17, 2025
f43a283
see if caching is problem
anthonykim1 Nov 17, 2025
183b5e5
Dont mix up profile and skip list when creating local terminal in remote
anthonykim1 Nov 17, 2025
9d167f0
Just handle wsl in this PR to make life simpler
anthonykim1 Nov 18, 2025
44e725f
Logs for debugging
anthonykim1 Nov 18, 2025
9fb14cc
Allow local to get backend by checking from createTerminal in termina…
anthonykim1 Nov 18, 2025
1b762fc
leave logs to debug, code doesnt work after prev commit
anthonykim1 Nov 19, 2025
3e21405
stringify for better logs. isLocalRemoteTerminal value is still false
anthonykim1 Nov 19, 2025
d984456
more and more logs
anthonykim1 Nov 19, 2025
15178bf
Bug fixed) Use Schemas.file instead of Shemas.vscodeFileResource
anthonykim1 Nov 19, 2025
114493a
Merge branch 'main' into anthonykim1/tryRemoteLocal2
anthonykim1 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/vs/workbench/contrib/terminal/browser/terminalService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,9 +968,12 @@ export class TerminalService extends Disposable implements ITerminalService {
// local terminal in a remote workspace as profile won't be used in those cases and these
// terminals need to be launched before remote connections are established.
const isLocalInRemoteTerminal = this._remoteAgentService.getConnection() && URI.isUri(options?.cwd) && options?.cwd.scheme === Schemas.vscodeFileResource;
this._logService.debug(`#terminalService#createTerminal: Value of isLocalInRemoteTerminal is: ${isLocalInRemoteTerminal}`);
if (this._terminalProfileService.availableProfiles.length === 0) {
this._logService.debug(`#terminalService#createTerminal: available profile length is zero`);
const isPtyTerminal = options?.config && 'customPtyImplementation' in options.config;
if (!isPtyTerminal && !isLocalInRemoteTerminal) {
this._logService.debug(`#terminalService#createTerminal: !isPtyTerminal and !isLocalInRemoteTerminal`);
if (this._connectionState === TerminalConnectionState.Connecting) {
mark(`code/terminal/willGetProfiles`);
}
Expand All @@ -982,20 +985,25 @@ export class TerminalService extends Disposable implements ITerminalService {
}

let config = options?.config;
this._logService.debug(`#terminalService#createTerminal: config ${config}`);
if (!config && isLocalInRemoteTerminal) {
this._logService.debug(`#terminalService#createTerminal: !config and isLocalInRemoteTerminal`);
const backend = await this._terminalInstanceService.getBackend(undefined);
const executable = await backend?.getDefaultSystemShell();
this._logService.debug(`#terminalService#createTerminal: backend is: ${backend} and executable is: ${executable}`);
if (executable) {
config = { executable };
this._logService.debug(`#terminalService#createTerminal: setting current config ${config} to ${executable}`);
}
}

if (!config) {
config = this._terminalProfileService.getDefaultProfile();
this._logService.debug(`#terminalService#createTerminal: !config, so set it to new value: ${config}`);
}

const shellLaunchConfig = config && 'extensionIdentifier' in config ? {} : this._terminalInstanceService.convertProfileToShellLaunchConfig(config || {});

this._logService.debug(`#terminalService#createTerminal: shellLaunchConfig is ${shellLaunchConfig}`);
// Get the contributed profile if it was provided
const contributedProfile = options?.skipContributedProfileCheck ? undefined : await this._getContributedProfile(shellLaunchConfig, options);

Expand Down
Loading