SDIT-1681: 🐛 Only output severity defects to sarif format #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergphillips
commented
Apr 26, 2024
| @@ -31,6 +31,7 @@ jobs: | |||
| format: 'sarif' | |||
| output: 'trivy-results.sarif' | |||
| exit-code: 1 | |||
| limit-severities-for-sarif: true | |||
There was a problem hiding this comment.
starting to get complicated. We're only interested in high and critical issues, but by default the sarif format retrieves all the issues. This is then compounded by the exit-code, that looks at whether any issues are in the output format and doesn't take into account that it is a sarif format. Would be nice to see all the issues in the security tab, but that doesn't look like it is possible according to aquasecurity/trivy-action#309.
mikehalmamoj
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.