Skip to content

Conversation

@ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Dec 29, 2025

What are the relevant tickets?

https://github.com/mitodl/hq/issues/9724

Description (What does it do?)

The plan is to move the tiptap editor code from ol-components to main app. The purpose is to consume the code which exists in main app as reusable code like drawer code and userList code. The decision was taken after having discussion with @ChristopherChudzicki

Screenshots (if appropriate):

image

How can this be tested?

We just need to verify all the implemented features working as per implementation

Additional Context

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

OpenAPI Changes

Show/hide 14 changes: 1 error, 0 warning, 13 info
14 changes: 1 error, 0 warning, 13 info
error	[api-path-removed-without-deprecation] at base/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources/bulk/
		api path removed without deprecation

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/courses/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/featured/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resource_display_info/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources/summary/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources/{id}/similar/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources/{id}/vector_similar/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learningpaths/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/podcast_episodes/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/podcasts/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/programs/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/video_playlists/
		added the new optional 'query' request parameter 'resource_id'

info	[new-optional-request-parameter] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/videos/
		added the new optional 'query' request parameter 'resource_id'


Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

@ahtesham-quraish ahtesham-quraish changed the title Ahtesham/editor component migration fix: editor component migration into main app Dec 29, 2025
@ahtesham-quraish ahtesham-quraish changed the base branch from main to ahtesham/drawer-branch December 29, 2025 14:09
@ahtesham-quraish ahtesham-quraish marked this pull request as ready for review December 30, 2025 07:53
@ahtesham-quraish ahtesham-quraish added the Needs Review An open Pull Request that is ready for review label Dec 30, 2025
Base automatically changed from ahtesham/drawer-branch to main January 5, 2026 13:58
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at all the changes here yet, but wanted to call out a different approach for the API change.

Additionally, could you resolve the conflicts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: Rather than adding a new action, let's just add to the existing LearningResourceFilter filterset—that's what controls the available query param filters on the view. Adding this

    id = NumberInFilter(
        label="A unique numeric identifier for the resources",
        field_name="id",
    )

should get exactly the behavior we want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done this change you can review it now.

@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/editor-component-migration branch from 8ae0792 to f96a1e3 Compare January 6, 2026 07:54
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request regarding the naming of the query param: just id, not ids. That matches how we do other params (e.g., readable_id) and reads better for "exploded" params, ?id=1&id=2&id=3, whereas right now it would be ?ids=1&ids=2&ids=3....

OpenAPI Diff Failure: I would suggest we ignore this, though it would have been better to not merge #2832 (or make the change requested here in that PR prior to merging. Lots of PRs open!).

@ahtesham-quraish ahtesham-quraish merged commit 1ba81e9 into main Jan 6, 2026
12 of 13 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/editor-component-migration branch January 6, 2026 16:31
@odlbot odlbot mentioned this pull request Jan 8, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants