-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add codespell #159
Merged
Merged
ci: add codespell #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
codespell
branch
from
September 26, 2024 07:09
8818ecc
to
7bd1f5a
Compare
thaJeztah
reviewed
Sep 26, 2024
kolyshkin
force-pushed
the
codespell
branch
from
September 27, 2024 01:02
7bd1f5a
to
38cc202
Compare
Rephrase the SIGURG prose to avoid using preemptible (or preemptable). Also, remove an inline comment which pretty much repeats what the function documentation already explained. Signed-off-by: Kir Kolyshkin <[email protected]>
Rename cleanP, fullP -> pClean, pFull. This is mostly to silence codespell, which thinks cleanP is a typo in cleanup. Kind of makes sense. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Rebased; no longer a draft. |
Also, remove capability/.codespellrc as it's no longer needed. Signed-off-by: Kir Kolyshkin <[email protected]>
tianon
approved these changes
Oct 11, 2024
@thaJeztah PTAL |
Merging with a single LGTM since the changes are minor; if anything comes up, lets fix is post merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos, rename some variables etc, add codespell job to CI.
Please see individual commits for details.
Currently a draft pending #162 merge.