Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codespell #159

Merged
merged 4 commits into from
Oct 30, 2024
Merged

ci: add codespell #159

merged 4 commits into from
Oct 30, 2024

Conversation

kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Sep 26, 2024

Fix typos, rename some variables etc, add codespell job to CI.

Please see individual commits for details.

Currently a draft pending #162 merge.

@kolyshkin kolyshkin marked this pull request as ready for review September 26, 2024 05:54
@kolyshkin kolyshkin marked this pull request as draft September 26, 2024 06:47
@kolyshkin kolyshkin marked this pull request as ready for review September 26, 2024 07:12
signal/signal.go Outdated Show resolved Hide resolved
capability/capability_test.go Outdated Show resolved Hide resolved
capability/capability_test.go Outdated Show resolved Hide resolved
capability/capability_test.go Outdated Show resolved Hide resolved
Rephrase the SIGURG prose to avoid using preemptible (or preemptable).

Also, remove an inline comment which pretty much repeats what the
function documentation already explained.

Signed-off-by: Kir Kolyshkin <[email protected]>
Rename cleanP, fullP -> pClean, pFull.

This is mostly to silence codespell, which thinks cleanP is a typo in
cleanup. Kind of makes sense.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Collaborator Author

Rebased; no longer a draft.

@kolyshkin kolyshkin marked this pull request as ready for review October 10, 2024 18:14
Also, remove capability/.codespellrc as it's no longer needed.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Collaborator Author

@thaJeztah PTAL

@kolyshkin
Copy link
Collaborator Author

Merging with a single LGTM since the changes are minor; if anything comes up, lets fix is post merge.

@kolyshkin kolyshkin merged commit 4e88a80 into moby:main Oct 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants