capability: use strings.CutPrefix; test improvements #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, make capability_test.go a separate package so we are limited to testing the external API (as opposed to e.g. state_linux_test.go in which we test internal stuff as well). Second, streamline the linux/non-linux code so it's easier to read and copy/paste (in general, we only want to check that non-linux functions can be called and return an error). Third, change some non-fatal errors to use t.Errorf. Fourth, use want/got everywhere in error messages, and add more context to some errors. Nothing here is critical or makes any noticeable impact on tests. Signed-off-by: Kir Kolyshkin <[email protected]>
This makes it slightly less cryptic (in particular, replacing a literal tab with "\t"), and also silences this codespell warning: > ./capability/capability_linux.go:311: nd ==> and, 2nd While at it, add a simple test for the method. Signed-off-by: Kir Kolyshkin <[email protected]>
Merged
kolyshkin
commented
Sep 27, 2024
| default: | ||
| if err == nil { | ||
| t.Fatal(runtime.GOOS, ": want error, got nil") | ||
| } | ||
| return | ||
| case "linux": |
There was a problem hiding this comment.
I like it that you can have default as the first case in switch; it improves readability in here (otherwise I would have to add a comment saying "Below is linux-only stuff").
|
@thaJeztah @tianon PTAL 🙏 I have some more changes that depend on these. |
tianon
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. Originally part of #159.