Skip to content

Conversation

@wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jan 7, 2026

Close #2676. Show HFBs in orange in map view and cross section plots. This needed functions to find a shared face given two adjacent cell numbers. We have a similar one in cvfdutil.py to find the shared face given cell vertices, but not given cell IDs.

Horizontal barriers are plotted as lines in map view and rectangular patches in cross section, vice versa for vertical barriers.

Map view, horizontal barrier

plot_hfb_horizontal

Map view, vertical barrier

plot_hfb_vertical

Map view, horizontal and vertical barriers (note bold orange cell faces on the upper right)

plot_hfb_horizontal_vertical

Cross section, horizontal barrier

xc_hfb_horizontal

Cross section, horizontal and vertical barriers

xc_hfb_horizontal_vertical

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 79.38144% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.7%. Comparing base (556c088) to head (924c27e).
⚠️ Report is 104 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/plot/plotutil.py 54.3% 26 Missing ⚠️
flopy/plot/crosssection.py 88.7% 8 Missing ⚠️
flopy/plot/map.py 90.9% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2677      +/-   ##
===========================================
+ Coverage     55.5%    72.7%   +17.2%     
===========================================
  Files          644      667      +23     
  Lines       124135   130014    +5879     
===========================================
+ Hits         68947    94650   +25703     
+ Misses       55188    35364   -19824     
Files with missing lines Coverage Δ
flopy/plot/map.py 81.5% <90.9%> (-0.6%) ⬇️
flopy/plot/crosssection.py 64.8% <88.7%> (-2.3%) ⬇️
flopy/plot/plotutil.py 51.4% <54.3%> (-5.5%) ⬇️

... and 552 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli added the bug label Jan 8, 2026
@wpbonelli wpbonelli added this to the 3.9.6 milestone Jan 8, 2026
@wpbonelli wpbonelli marked this pull request as ready for review January 8, 2026 13:43
@jdhughes-dev jdhughes-dev merged commit aad0682 into modflowpy:develop Jan 9, 2026
20 checks passed
@wpbonelli wpbonelli deleted the fix-2676 branch January 9, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: flopy cannot plot HFB

2 participants