refactor(grid): consistent API for get_cell_vertices #2678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Grid.get_cell_vertices()method looked/worked different depending on the grid type. Make it consistent across all three grid types by supporting bothcellidandnodekeyword arguments and being lenient about what's passed tocellidi.e. accept a node number, a fully-sized tuple, or an "abbreviated" tuple lacking layer index. Cell ID and node number are conceptually distinct but til nowVertexGridandUnstructuredGridmethods had a single parametercellidsupporting (for vertex) or expecting (for unstructured) a node number, which we don't want to break. And continue also supportingiandjforStructuredGrid.Noticed these inconsistencies when working on #2677