-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple-URI support in parse_uri
and make_uri
#9756
base: master
Are you sure you want to change the base?
Conversation
It doesn't properly call make_uri in wallet2.cpp
…ncy checks and improve error messages.
Thank you. The |
Alright, will ping you when it's done. It seems like I didn't update the python source files to comply with the new updated C++ code. |
As illustrated by the test failures, this PR would introduce a backwards-incompatible change to the wallet RPC interface, which generally should not be done. |
Two possible ways to address the compatibility issue:
|
…allet.py for handling both new and old formats plus rewrite uri.py to handle tests properly. Rewrite was necessary to remove all broken tests written previously, restore the file and modify the way it accesses data (the structure is different).
…since it's in wallet2.h
…func to handle `=` and `?` properly in desc and recipient name.
…tils::conver_to_url_format
@selsta @iamamyth So after a long trial and error, I've managed to reach all the requirements. It passes all the tests and is backwards compatible (fully or partially based on how you view it). The new format is basically the old format but for the multiple values, they're separated by a delimitter which in this case is a
becomes
The rest of the data, that is:
remains the same. To overcome this, I could introduce a new legacy data type and slightly change the code to adjust it. Other than this, what do you think? |
@selsta Please have a look at the code and tell me if to make it ready for review since it's a draft. |
@selsta ping. |
I will take a closer look within the next days. |
Alright. I won't ping you till Sunday, but don't forget to reply. |
This pull request addresses the issues raised in #7737 and introduces a new feature to the Monero codebase: multi-URL support for
parse_uri
andmake_uri
functions.Key Changes:
i
withj
for proper iteration).Notes:
This PR was rewritten from the latest Monero repository rather than being forked from the original issue (#7737).
All builds are successfully passing, and existing tests have cleared without any regressions.
Please check for any overlooked issues or mistakes, especially in the multi-URL parsing logic.
Validate the new test cases and suggest improvements to ensure robustness.