Skip to content

DOCSP-48572 Remove automatic init #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented Mar 20, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48572
Staging - https://deploy-preview-101--docs-c.netlify.app/install-from-source/#configuring-for-libbson

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for docs-c ready!

Name Link
🔨 Latest commit 52c91cc
🔍 Latest deploy log https://app.netlify.com/sites/docs-c/deploys/67dc2b69469c35000843abc9
😎 Deploy Preview https://deploy-preview-101--docs-c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion

Comment on lines 269 to 270
The ``ENABLE_EXTRA_ALIGNMENT`` is part
of ``mongo-c-driver``, and corresponds to a deprecated feature that is only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: clarify what ENABLE_EXTRA_ALIGNMENT is; I'd also remove the comma before the dependent clause

Suggested change
The ``ENABLE_EXTRA_ALIGNMENT`` is part
of ``mongo-c-driver``, and corresponds to a deprecated feature that is only
The ``ENABLE_EXTRA_ALIGNMENT`` argument is part
of ``mongo-c-driver`` and corresponds to a deprecated feature that is only

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM!

@jordan-smith721 jordan-smith721 merged commit a696ccb into mongodb:master Mar 20, 2025
5 checks passed
@jordan-smith721 jordan-smith721 deleted the DOCSP-48572-remove-auto-init branch March 20, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants