DOCSP-48572 Remove automatic init #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Mar 20, 2025
Collaborator
norareidy
left a comment
norareidy
left a comment
There was a problem hiding this comment.
LGTM with a small suggestion
source/install-from-source.txt
Outdated
Comment on lines
269
to
270
| The ``ENABLE_EXTRA_ALIGNMENT`` is part | ||
| of ``mongo-c-driver``, and corresponds to a deprecated feature that is only |
Collaborator
There was a problem hiding this comment.
S: clarify what ENABLE_EXTRA_ALIGNMENT is; I'd also remove the comma before the dependent clause
Suggested change
| The ``ENABLE_EXTRA_ALIGNMENT`` is part | |
| of ``mongo-c-driver``, and corresponds to a deprecated feature that is only | |
| The ``ENABLE_EXTRA_ALIGNMENT`` argument is part | |
| of ``mongo-c-driver`` and corresponds to a deprecated feature that is only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48572
Staging - https://deploy-preview-101--docs-c.netlify.app/install-from-source/#configuring-for-libbson
Self-Review Checklist