Skip to content

DOCSP-48572 Remove automatic init #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

DOCSP-48572 Remove automatic init #101

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ef6300
Remove auto init
jordan-smith721 Mar 20, 2025
86885de
edit wording
jordan-smith721 Mar 20, 2025
52c91cc
feedback
jordan-smith721 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions source/install-from-source.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ the project with both ``libbson`` and ``libmongoc``:

$ cmake -S $SOURCE -B $BUILD \
-D ENABLE_EXTRA_ALIGNMENT=OFF \
-D ENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF \
-D CMAKE_BUILD_TYPE=RelWithDebInfo \
-D BUILD_VERSION="$VERSION" \
-D ENABLE_MONGOC=OFF
Expand All @@ -267,10 +266,10 @@ messages and information. Ensure that configuration succeeds before proceeding.
results. This should be set to the same value as the version of the source
driver that was downloaded in :ref:`get-src`.

The ``ENABLE_EXTRA_ALIGNMENT`` and ``ENABLE_AUTOMATIC_INIT_AND_CLEANUP`` are part
of ``mongo-c-driver``, and correspond to deprecated features that are only
The ``ENABLE_EXTRA_ALIGNMENT`` is part
of ``mongo-c-driver``, and corresponds to a deprecated feature that is only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: clarify what ENABLE_EXTRA_ALIGNMENT is; I'd also remove the comma before the dependent clause

Suggested change
The ``ENABLE_EXTRA_ALIGNMENT`` is part
of ``mongo-c-driver``, and corresponds to a deprecated feature that is only
The ``ENABLE_EXTRA_ALIGNMENT`` argument is part
of ``mongo-c-driver`` and corresponds to a deprecated feature that is only

enabled by default for ABI compatibility purposes. It is highly recommended to
disable these features whenever possible.
disable this feature whenever possible.

The ``ENABLE_MONGOC=OFF`` argument disabled building ``libmongoc``. We'll build
that in the next section.
Expand Down