Convert SQLException's to Hibernate ORM exception's. #130

vbabanin · 2025-10-09T00:36:28Z

HIBERNATE-95

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

...ationTest/java/com/mongodb/hibernate/exception/AbstractExceptionHandlingIntegrationTest.java

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Remove redundant tests.

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

stIncMale

The last reviewed commit is 0cda4bc.

I reviewed everything including MongoExtension but the tests.

src/integrationTest/java/com/mongodb/hibernate/junit/MongoExtension.java

src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

…nsion.java Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale

The last reviewed commit is ~~17af7e8~~, ~~9d0b258~~, ~~1a22030~~, 95d3448.

I reviewed everything but ExceptionHandlingIntegrationTest.

src/integrationTest/java/com/mongodb/hibernate/ExceptionHandlingIntegrationTest.java

…tionHandlingIntegrationTest.java Co-authored-by: Valentin Kovalenko <[email protected]>

The base branch was changed.

# Conflicts: # src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

vbabanin and others added 13 commits September 10, 2025 22:40

Introduce batch support.

4b65eb2

Add tests and refactor MongoStatements.

5b17d58

Merge branch 'main' into HIBERNATE-40

3f1ebcb

Rename tests.

ded2bb7

Rename variables.

92d9c41

Rename methods, add tests.

b78cb77

Revert to private.

a7f7792

Add JDBC exception handling.

7372d56

Apply spotless.

330de0f

Apply spotless.

5c81496

Revert SqlTransientException handling.

e4d7afd

Remove SQlConsumer.

183aafc

Convert SQLException's to Hibernate ORM exception's.

9128c9e

HIBERNATE-95

vbabanin requested a review from a team as a code owner October 9, 2025 00:36

vbabanin requested review from nhachicha and removed request for a team and nhachicha October 9, 2025 00:36

Remove public modifier.

35dbc91

vbabanin self-assigned this Oct 16, 2025

vbabanin and others added 5 commits October 17, 2025 14:34

Remove disabled tests.

6fe48b4

Fix issues.

9577603

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

76acbc5

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

39df511

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

11a2b07

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

vbabanin commented Oct 25, 2025

View reviewed changes

...ationTest/java/com/mongodb/hibernate/exception/AbstractExceptionHandlingIntegrationTest.java Outdated Show resolved Hide resolved

stIncMale reviewed Oct 25, 2025

View reviewed changes

...ationTest/java/com/mongodb/hibernate/exception/AbstractExceptionHandlingIntegrationTest.java Outdated Show resolved Hide resolved

vbabanin commented Oct 25, 2025

View reviewed changes

...ationTest/java/com/mongodb/hibernate/exception/AbstractExceptionHandlingIntegrationTest.java Outdated Show resolved Hide resolved

vbabanin and others added 3 commits October 27, 2025 13:39

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

510bc2d

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Fix batch update count reporting.

6faa9cb

Remove redundant tests.

Merge branch 'main' into HIBERNATE-40

b27ef0e

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

vbabanin added 5 commits October 27, 2025 18:43

Make NULL_SQL_STATE private.

7c8a702

Remove final in parameters.

51103be

Merge branch 'HIBERNATE-40' into HIBERNATE-95

06b1ee0

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

Move failpoint to beforeEach and afterEach.

bbade89

Add afterAll.

0cda4bc

stIncMale mentioned this pull request Oct 29, 2025

Introduce batch support. #136

Merged

stIncMale requested changes Oct 29, 2025

View reviewed changes

vbabanin and others added 2 commits October 29, 2025 13:14

Update src/integrationTest/java/com/mongodb/hibernate/junit/MongoExte…

ad94e8f

…nsion.java Co-authored-by: Valentin Kovalenko <[email protected]>

Use JdbcException for all cases.

17af7e8

stIncMale approved these changes Oct 29, 2025

View reviewed changes

stIncMale reviewed Oct 30, 2025

View reviewed changes

src/integrationTest/java/com/mongodb/hibernate/ExceptionHandlingIntegrationTest.java Show resolved Hide resolved

src/integrationTest/java/com/mongodb/hibernate/ExceptionHandlingIntegrationTest.java Show resolved Hide resolved

vbabanin and others added 2 commits October 30, 2025 14:16

Update src/integrationTest/java/com/mongodb/hibernate/exception/Excep…

c7a67dc

…tionHandlingIntegrationTest.java Co-authored-by: Valentin Kovalenko <[email protected]>

Move tests to .*hibernate root package.

9d0b258

vbabanin requested a review from stIncMale October 30, 2025 21:18

stIncMale previously approved these changes Oct 30, 2025

View reviewed changes

vbabanin deleted the branch mongodb:main October 30, 2025 23:33

vbabanin closed this Oct 30, 2025

vbabanin reopened this Oct 30, 2025

vbabanin changed the base branch from HIBERNATE-40 to main October 30, 2025 23:35

vbabanin added 2 commits October 30, 2025 16:39

Spotless apply.

1a22030

stIncMale previously approved these changes Oct 30, 2025

View reviewed changes

Merge branch 'main' into HIBERNATE-95

8414f45

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

vbabanin requested a review from stIncMale October 30, 2025 23:52

vbabanin dismissed stIncMale’s stale review via 8414f45 October 30, 2025 23:52

Spotless apply.

95d3448

stIncMale approved these changes Oct 30, 2025

View reviewed changes

vbabanin merged commit 88b9a2c into mongodb:main Oct 30, 2025
5 of 6 checks passed

vbabanin deleted the HIBERNATE-95 branch October 31, 2025 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert SQLException's to Hibernate ORM exception's. #130

Convert SQLException's to Hibernate ORM exception's. #130

vbabanin commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Convert SQLException's to Hibernate ORM exception's. #130

Convert SQLException's to Hibernate ORM exception's. #130

Conversation

vbabanin commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stIncMale left a comment •

edited

Loading

stIncMale left a comment •

edited

Loading