Introduce batch support. #136

vbabanin · 2025-10-17T20:11:25Z

https://jira.mongodb.org/browse/HIBERNATE-40
https://jira.mongodb.org/browse/HIBERNATE-35

evergreen-ci-prod · 2025-10-17T20:11:29Z

There is an existing patch(es) for this commit SHA:

Evergreen patch with PR

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

vbabanin · 2025-10-17T20:13:19Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

-    @Override
-    public void addBatch(String mql) throws SQLException {
-        checkClosed();
-        throw new SQLFeatureNotSupportedException("TODO-HIBERNATE-35 https://jira.mongodb.org/browse/HIBERNATE-35");
-    }
-
-    @Override
-    public void clearBatch() throws SQLException {
-        checkClosed();
-        throw new SQLFeatureNotSupportedException("TODO-HIBERNATE-35 https://jira.mongodb.org/browse/HIBERNATE-35");
-    }
-
-    @Override
-    public int[] executeBatch() throws SQLException {
-        checkClosed();
-        closeLastOpenResultSet();
-        throw new SQLFeatureNotSupportedException("TODO-HIBERNATE-35 https://jira.mongodb.org/browse/HIBERNATE-35");
-    }


These are not implemented because Hibernate relies on PreparedStatement methods for batching.

stIncMale · 2025-10-22T22:06:38Z

Let's remove MongoStatement.executeUpdate(String) - Hibernate ORM does not use it. We should do it after dealing with the current PR.

Update: we decided to leave it, as removing it causes code restructuring (otherwise the code looks weird), and we don't want to do that. Continue having this method seems to be a lesser burden than removing it.

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

stIncMale · 2025-10-24T22:05:40Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+
+        @ParameterizedTest(name = "test not supported update elements. Parameters: option={0}")
+        @ValueSource(strings = {"hint", "collation", "arrayFilters", "sort", "upsert", "c"})
+        void testNotSupportedUpdateElements(String unsupportedElement) {


These are not called "element", they are called "option". See https://www.mongodb.com/docs/manual/reference/command/update/. Let's make all the changes needed to reflect that.

The same applies to testNotSupportedDeleteElements.

As discussed during the walkthrough - renamed to "field".

stIncMale · 2025-10-24T22:12:08Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+        }
+
+        @ParameterizedTest(name = "test not supported update elements. Parameters: option={0}")
+        @ValueSource(strings = {"hint", "collation", "arrayFilters", "sort", "upsert", "c"})


I suspect, we should use both keys and values, like "hint: 'abc'", here, as otherwise the { _id: 1 } value currently used as the value of each option is not always valid. If we use a valid value for each option, then having an exception makes it more clear the the option name itself caused it.

The same applies to testNotSupportedDeleteElements.

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale

Finished reviewing MongoPreparedStatementIntegrationTests. So far I have the following reviewed:

AbstractQueryIntegrationTests
LimitOffsetFetchClauseIntegrationTests
BatchUpdateIntegrationTests
MongoPreparedStatementIntegrationTests

We worked thoroughly on MongoPreparedStatement, MongoStatement during the code walkthrough. But I will still need to look at them once the changes are pushed.

The last reviewed commit is 11a2b07.

stIncMale · 2025-10-27T14:04:04Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+                            .returns(0, BatchUpdateException::getErrorCode);
+                } catch (SQLException e) {
+                    throw new RuntimeException(e);
+                }


We don't need this catch (SQLException e) here and in any other test in ExecuteBatchTests.

Pre-existing test methods need it because they implement Function, while the new tests implement Work, and its Work.execute method throws SQLException.

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

stIncMale · 2025-10-27T14:14:38Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+
+        @Test
+        void testBatchInsert() {
+            var batchCount = 3;


Maybe let's call it batchSize here and in other places? Feels more natural, and is closer to hibernate.jdbc.batch_size, which has the same meaning.

Neither JDBC API documentation, nor the JDBC specification seem to use "count" to refer to the number of commands in a batch.

stIncMale · 2025-10-27T14:32:33Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+            for (int i = 0; i < batchCount; i++) {
+                expectedDocs.add(BsonDocument.parse(format(
+                        """
+                        {
+                            "_id": %d,
+                            "title": "Book %d"
+                        }""",
+                        i + 1, i + 1)));


Let's use for (int i = 1; i <= batchCount; i++), especially given that above we used these exact boundaries, so that we could use i, i instead of i + 1, i + 1. The same suggestion applies to testBatchUpdate.

stIncMale · 2025-10-27T14:45:55Z

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

+        }
+
+        @Test
+        @DisplayName("Test statement’s batch queue is reset once executeBatch returns")


The API documentation of PreparedStatement.addBatch calls it "batch of commands". I found "qeue" neither in the API documentation nor in the JDBC specification. Unless I missed it, and "queue" is the term that is actually used, let's say either "statement’s batch" or "statement's batch of commands".

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Remove redundant tests.

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

stIncMale · 2025-10-28T02:47:03Z

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

+        }
+        if (!commandDescription.isUpdate()) {
+            throw new SQLFeatureNotSupportedException(
+                    format("Unsupported command for batch operation: %s", commandDescription.getCommandName()));


"operation" here, and also in "Unsupported command for query operation"/"Unsupported command for update operation" does not refer to the operations executable via MongoClient. Rather, it refers to the executeBatch, executeQuery, executeUpdate methods. In EXCEPTION_MESSAGE_OPERATION_FAILED, EXCEPTION_MESSAGE_TIMEOUT it, on the other hand, refers to the operation executable via MongoClient, as far as I understand.

I fail to think of a term that seems both suitable here and not conflating with other meanings (operation is specific to MongoClient, and command is specific to the DBMS, which is MongoDB in our case). So I propose us to just say "Unsupported command for executeUpdate"/"Unsupported command for executeQuery"/"Unsupported command for executeUpdate".

stIncMale · 2025-10-28T02:56:18Z

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

        checkClosed();
-        throw new SQLFeatureNotSupportedException("TODO-HIBERNATE-35 https://jira.mongodb.org/browse/HIBERNATE-35");
+        checkAllParametersSet();
+        commandBatch.add(command.clone());


[optional]

This check may not help us at all, as batching parameterless commands is hardly practical, but neither will it hurt, and it makes it clear that we have to clone specifically because of the parameter value setters.

Suggested change

commandBatch.add(command.clone());

commandBatch.add(parameterValueSetters.isEmpty() ? command : command.clone());

stIncMale · 2025-10-28T14:14:32Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+            return returnsResultSet;
+        }
+
+        static CommandDescription fromString(String commandName) throws SQLFeatureNotSupportedException {


of/fromName?

stIncMale · 2025-10-28T16:31:50Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java


+    private void checkSupportedQueryCommand(BsonDocument command) throws SQLException {
+        var commandDescription = getCommandDescription(command);
+        if (commandDescription.isUpdate()) {


A command used as a query also must produce a result set, mustn't it?

if (commandDescription.isUpdate() || !commandDescription.returnsResultSet()) {

However, if we do #136 (comment), then we don't need any changes here.

stIncMale · 2025-10-28T16:34:32Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+         * Indicates whether the command is used in {@code executeUpdate(...)} or {@code executeBatch()} methods.
+         *
+         * @return true if the command is used in update operations, false if it is used in query operations.


This method indicates only whether a command may be used in executeUpdate/executeBatch

Suggested change

* Indicates whether the command is used in {@code executeUpdate(...)} or {@code executeBatch()} methods.

*

* @return true if the command is used in update operations, false if it is used in query operations.

* Indicates whether the command may be used in {@code executeUpdate(...)} or {@code executeBatch()} methods.

*

* @return true if the command may be used in update operations, false if it is used in query operations.

stIncMale · 2025-10-28T21:06:19Z

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

+    }
+
+    /** @throws BatchUpdateException if any of the commands in the batch attempts to return a result set. */
+    private void checkSupportedBatchCommand(BsonDocument command)


Suggested change

private void checkSupportedBatchCommand(BsonDocument command)

private static void checkSupportedBatchCommand(BsonDocument command)

stIncMale · 2025-10-28T21:09:00Z

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

        closeLastOpenResultSet();
        checkAllParametersSet();
-        return executeQueryCommand(command);
+        return executeQuery(command);


checkSupportedQueryCommand is missing here, and it should be after checkAllParametersSet, similarly to how it is in executeUpdate.

Suggested change

return executeQuery(command);

checkSupportedQueryCommand(command);

return executeQuery(command);

stIncMale · 2025-10-28T21:11:33Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+    static final int NO_ERROR_CODE = 0;
+    static final int[] EMPTY_BATCH_RESULT = new int[0];
+
+    @Nullable static final String NULL_SQL_STATE = null;


This annotation applies to ElementType.TYPE_USE:

Suggested change

@Nullable static final String NULL_SQL_STATE = null;

static final String @Nullable NULL_SQL_STATE = null;

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale

Almost done, but some more review work (or, rather, trying and maybe proposing) is needed in the area of exception handling and transaction handling. I continue reviewing.

stIncMale · 2025-10-28T22:05:23Z

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

+                            .formatted(commandDescription.getCommandName()),
+                    NULL_SQL_STATE,
+                    NO_ERROR_CODE,
+                    NULL_UPDATE_COUNTS);


Why do we use null here and new int[0] in the other place? The API/specification does not seem to specify any difference between them. I propose us to use the same value.

stIncMale · 2025-10-28T22:07:53Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+    private static final String EXCEPTION_MESSAGE_OPERATION_FAILED = "Failed to execute operation";
+    private static final String EXCEPTION_MESSAGE_TIMEOUT = "Timeout while waiting for operation to complete";
+    static final int NO_ERROR_CODE = 0;
+    static final int[] EMPTY_BATCH_RESULT = new int[0];


We name it EMPTY_BATCH_RESULT here, but we name NULL_UPDATE_COUNTS conceptually the same thing in the other place. Also, the method we use EMPTY_BATCH_RESULT in is called calculateBatchUpdateCounts.

Let's rename this to EMPTY_UPDATE_COUNTS.

stIncMale · 2025-10-28T22:43:36Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java


 class MongoStatement implements StatementAdapter {
+    private static final String EXCEPTION_MESSAGE_OPERATION_FAILED = "Failed to execute operation";
+    private static final String EXCEPTION_MESSAGE_TIMEOUT = "Timeout while waiting for operation to complete";


Should it be named EXCEPTION_MESSAGE_OPERATION_TIMED_OUT similarly to how EXCEPTION_MESSAGE_OPERATION_FAILED is named?

stIncMale · 2025-10-28T23:09:36Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+
+        private WriteModelConverter() {}
+
+        private static void convertToWriteModels(


[optional]

This is the only program element in WriteModelConverter that is intended to be used outside of this class. Let's make it package-access to express that? Note that since WriteModelConverter itself is private, the making its method package-access does not really make it more visible.

If you agree with such an approach, then the same applies to the constructor, add, findCommandIndex in WriteModelsToCommandMapper.

stIncMale · 2025-10-28T23:33:06Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+        INSERT("insert", false, true),
+        UPDATE("update", false, true),
+        DELETE("delete", false, true),
+        AGGREGATE("aggregate", true, false);


[optional]

Let's link to the command docs for convenience.

Suggested change

INSERT("insert", false, true),

UPDATE("update", false, true),

DELETE("delete", false, true),

AGGREGATE("aggregate", true, false);

/** See <a href="https://www.mongodb.com/docs/manual/reference/command/insert/">{@code insert}</a>. */

INSERT("insert", false, true),

/** See <a href="https://www.mongodb.com/docs/manual/reference/command/update/">{@code update}</a>. */

UPDATE("update", false, true),

/** See <a href="https://www.mongodb.com/docs/manual/reference/command/delete/">{@code delete}</a>. */

DELETE("delete", false, true),

/** See <a href="https://www.mongodb.com/docs/manual/reference/command/aggregate/">{@code aggregate}</a>. */

AGGREGATE("aggregate", true, false);

stIncMale · 2025-10-29T04:00:17Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+        var writeErrors = mongoBulkWriteException.getWriteErrors();
+        var writeConcernError = mongoBulkWriteException.getWriteConcernError();
+        if (writeConcernError == null) {
+            if (!writeErrors.isEmpty()) {


The API documentation of MongoBulkWriteException.getWriteConcernError says

The write concern error, which may be null (in which case the list of errors will not be empty).

That is, if writeConcernError == null, we know that writeErrors is not empty, and we should assert than rather than check.

Furthermore, since our bulk write is ordered, which is the default, we know that the size of writeErrors is 1. Thus, we should have assertTrue(writeErrors.size() == 1) instead of if (!writeErrors.isEmpty()).

I seem to remember us discussing this.

stIncMale · 2025-10-29T04:37:54Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+        if (writeConcernError == null) {
+            if (!writeErrors.isEmpty()) {
+                var failedModelIndex = writeErrors.get(0).getIndex();
+                var commandIndex = writeModelsToCommandMapper.findCommandIndex(failedModelIndex);


commandIndex -> failedCommandIndexInBatch?

stIncMale · 2025-10-29T04:49:36Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+        private static final String UNSUPPORTED_MESSAGE_STATEMENT_FIELD = "Unsupported field in %s statement: [%s]";
+        private static final String UNSUPPORTED_MESSAGE_COMMAND_FIELD = "Unsupported field in %s command: [%s]";


These are message templates, not messages.

Shouldn't the first %s be also wrapped in [, ]?

Suggested change

private static final String UNSUPPORTED_MESSAGE_STATEMENT_FIELD = "Unsupported field in %s statement: [%s]";

private static final String UNSUPPORTED_MESSAGE_COMMAND_FIELD = "Unsupported field in %s command: [%s]";

private static final String UNSUPPORTED_MESSAGE_TEMPLATE_STATEMENT_FIELD =

"Unsupported field in [%s] statement: [%s]";

private static final String UNSUPPORTED_MESSAGE_TEMPLATE_COMMAND_FIELD =

"Unsupported field in [%s] command: [%s]";

stIncMale · 2025-10-29T05:06:28Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+        private static final Set<String> SUPPORTED_INSERT_COMMAND_FIELDS = Set.of("documents");
+
+        private static final Set<String> SUPPORTED_UPDATE_COMMAND_FIELDS = Set.of("updates");
+        private static final Set<String> SUPPORTED_UPDATE_STATEMENT_FIELDS = Set.of("q", "u", "multi");
+
+        private static final Set<String> SUPPORTED_DELETE_COMMAND_FIELDS = Set.of("deletes");
+        private static final Set<String> SUPPORTED_DELETE_STATEMENT_FIELDS = Set.of("q", "limit");


[optional]

What do you think about moving these to CommandDescription? That way the information tightly related to commands stays mostly there.

P.S. At first I thought about moving them there as instance methods, potentially with the checks, but then I realized that different commands have different structure (for example, aggregate does not have statements), which makes such endeavour non-trivial.

stIncMale · 2025-10-29T05:43:31Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+
+        private static void checkFields(
+                CommandDescription commandDescription,
+                String exceptionMessage,


This is a template, not a message: exceptionMessage -> exceptionMessageTemplate.

stIncMale

The last reviewed commit is afd8853.

I reviewed everything but:

MongoStatementTests
MongoPreparedStatementTests
the changes to MongoPreparedStatementIntegrationTests after 510bc2d (this commit and the changes before it were reviewed)

stIncMale · 2025-10-29T06:29:18Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

-
+            var collection = getCollection(commandDescription, command);
            var pipeline = command.getArray("pipeline").stream()
                    .map(BsonValue::asDocument)


command.getArray("pipeline") may throw BsonInvalidOperationException, which before we started supporting native queries wasn't possible.

BsonValue::asDocument may also result in BsonInvalidOperationException for the same reason.

We start the transaction before obtaining collection, dealing with the pipeline, really for no good reason.

Previously this wasn't needed because there was no native queries support. We should handle these exceptions here similarly to getCollection.

stIncMale · 2025-10-29T09:09:32Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

-    int executeUpdateCommand(BsonDocument command) throws SQLException {
+    int[] executeBatch(List<? extends BsonDocument> commandBatch) throws SQLException {
+        var firstCommandInBatch = commandBatch.get(0);
+        int commandBatchSize = commandBatch.size();


Suggested change

int commandBatchSize = commandBatch.size();

var commandBatchSize = commandBatch.size();

stIncMale · 2025-10-29T09:10:49Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

-            throw new SQLException("Failed to execute update command", e);
+            var writeModels = new ArrayList<WriteModel<BsonDocument>>(commandBatchSize);
+            writeModelsToCommandMapper = new WriteModelsToCommandMapper(commandBatchSize);
+            for (BsonDocument command : commandBatch) {


Suggested change

for (BsonDocument command : commandBatch) {

for (var command : commandBatch) {

stIncMale · 2025-10-29T09:16:05Z

src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

+    ResultSet executeQuery(BsonDocument command) throws SQLException {
+        var commandDescription = getCommandDescription(command);
        try {
            startTransactionIfNeeded();


Let's shift everything above try down so that the lines are at the top of the try block.

Let's move the startTransactionIfNeeded() call right before collection.aggregate. We should not start a transaction before it is actually needed.

This also applies to executeUpdate, executeBatch. Here is what I mean: 2d09493 (the commit is only for expressing what I mean, whether to cherry-pick it or do the changes otherwise is up to you).

vbabanin and others added 12 commits September 10, 2025 22:40

Introduce batch support.

4b65eb2

Add tests and refactor MongoStatements.

5b17d58

Merge branch 'main' into HIBERNATE-40

3f1ebcb

Rename tests.

ded2bb7

Rename variables.

92d9c41

Rename methods, add tests.

b78cb77

Revert to private.

a7f7792

Add JDBC exception handling.

7372d56

Apply spotless.

330de0f

Apply spotless.

5c81496

Revert SqlTransientException handling.

e4d7afd

Remove SQlConsumer.

183aafc

vbabanin self-assigned this Oct 17, 2025

vbabanin requested a review from a team as a code owner October 17, 2025 20:11

vbabanin requested review from nhachicha and removed request for a team October 17, 2025 20:11

vbabanin requested review from stIncMale and removed request for nhachicha October 17, 2025 20:11

vbabanin commented Oct 17, 2025

View reviewed changes

Fix issues.

9577603

stIncMale requested changes Oct 25, 2025

View reviewed changes

vbabanin and others added 3 commits October 24, 2025 21:42

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

76acbc5

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

39df511

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

11a2b07

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale requested changes Oct 27, 2025

View reviewed changes

vbabanin and others added 3 commits October 27, 2025 13:39

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

510bc2d

…redStatementIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Fix batch update count reporting.

6faa9cb

Remove redundant tests.

Merge branch 'main' into HIBERNATE-40

b27ef0e

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

vbabanin added 2 commits October 27, 2025 18:43

Make NULL_SQL_STATE private.

7c8a702

Remove final in parameters.

51103be

vbabanin requested review from Copilot and stIncMale October 28, 2025 03:19

vbabanin added 4 commits October 28, 2025 10:21

Remove catch.

4317e2f

Use constants.

2b5be78

Remove accidental use of NO_ERROR_CODE.

40c75cf

Consolidate batch execution logic in one place.

91a88f1

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Remove redundunt methods.

9435785

stIncMale requested changes Oct 28, 2025

View reviewed changes

vbabanin and others added 2 commits October 28, 2025 16:10

Update src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

46d4682

Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

afd8853

Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale requested changes Oct 29, 2025

View reviewed changes

stIncMale mentioned this pull request Oct 29, 2025

Convert SQLException's to Hibernate ORM exception's. #130

Open

stIncMale requested changes Oct 29, 2025

View reviewed changes

	commandBatch.add(command.clone());
	commandBatch.add(parameterValueSetters.isEmpty() ? command : command.clone());

	private void checkSupportedBatchCommand(BsonDocument command)
	private static void checkSupportedBatchCommand(BsonDocument command)

	return executeQuery(command);
	checkSupportedQueryCommand(command);
	return executeQuery(command);

	@Nullable static final String NULL_SQL_STATE = null;
	static final String @Nullable NULL_SQL_STATE = null;


		private WriteModelConverter() {}

		private static void convertToWriteModels(

		private static final String UNSUPPORTED_MESSAGE_STATEMENT_FIELD = "Unsupported field in %s statement: [%s]";
		private static final String UNSUPPORTED_MESSAGE_COMMAND_FIELD = "Unsupported field in %s command: [%s]";

-        private static final String UNSUPPORTED_MESSAGE_STATEMENT_FIELD = "Unsupported field in %s statement: [%s]";
-        private static final String UNSUPPORTED_MESSAGE_COMMAND_FIELD = "Unsupported field in %s command: [%s]";
+        private static final String UNSUPPORTED_MESSAGE_TEMPLATE_STATEMENT_FIELD =
+                "Unsupported field in [%s] statement: [%s]";
+        private static final String UNSUPPORTED_MESSAGE_TEMPLATE_COMMAND_FIELD =
+                "Unsupported field in [%s] command: [%s]";

	int commandBatchSize = commandBatch.size();
	var commandBatchSize = commandBatch.size();

	for (BsonDocument command : commandBatch) {
	for (var command : commandBatch) {

Uh oh!

Introduce batch support. #136

Are you sure you want to change the base?

Introduce batch support. #136

Conversation

vbabanin commented Oct 17, 2025

Uh oh!

evergreen-ci-prod bot commented Oct 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stIncMale commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbabanin Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stIncMale Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

stIncMale commented Oct 22, 2025 •

edited

Loading

vbabanin Oct 28, 2025 •

edited

Loading

stIncMale Oct 28, 2025 •

edited

Loading