Fix PHP 8.5 deprecations of (integer), (long) and (boolean) casts
#1758
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses PHP 8.5 deprecation warnings by replacing non-canonical cast syntax with modern canonical equivalents. The PR updates cast expressions from (integer), (boolean), and (double) to their canonical forms (int), (bool), and (float) respectively, and modernizes string function usage by replacing strpos() checks with str_contains().
- Updates all cast expressions to use canonical PHP syntax
- Modernizes string containment checks using
str_contains() - Updates rector/rector dependency and configuration to enable automated fixes
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates rector/rector dependency to ^2.1.4 |
| rector.php | Modernizes rector configuration and adds RenameCastRector rule |
| src/functions.php | Fixes deprecated (integer) casts to (int) |
| src/Operation/*.php | Updates deprecated cast expressions in operation classes |
| src/Model/*.php | Replaces deprecated casts in model classes |
| src/GridFS/*.php | Updates cast expressions in GridFS components |
| src/MapReduceResult.php | Fixes deprecated cast in MapReduceResult |
| tests/**/*.php | Updates deprecated casts in test files |
| tools/*.php | Modernizes string containment checks using str_contains() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| $rectorConfig->rule(StaticDataProviderClassMethodRector::class); | ||
|
|
||
| ]) | ||
| ->withPhpSets(php74: true) |
There was a problem hiding this comment.
php74: true could be dropped in order to automatically upgrade the code to the PHP version defined in composer.json, 8.1 in this case. Doing this changes over 250 files.
mickverm
force-pushed
the
php-85-deprecations
branch
from
34e07d0 to
602fc2e
Compare
GromNaN
changed the title
(integer), (long) and (boolean) casts
My goal was to fix the following deprecations when using this library on PHP 8.5(-rc):
In order to do this, I updated
rector/rectorto^2.1.4so that I could make use of theRenameCastRector-rule. In the meantime, I also modernized the rector configuration.I opted to fix this on the v1.21 branch, I could rebase this on any other branch if deemed required.