Conversation
This was referenced Mar 24, 2026
Collaborator
Author
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
c38e130 to
6de2ce2
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
from
6fa9170 to
4aeb078
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
6de2ce2 to
68992ec
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
from
4aeb078 to
14b8dcc
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
68992ec to
e96d0a3
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
2 times, most recently
from
fdfe9f4 to
66c6cd4
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
e96d0a3 to
02e7ab3
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
from
66c6cd4 to
cfcb2d3
Compare
nickweinberger
approved these changes
Mar 30, 2026
mongoimport/mongoimport_test.go
Outdated
| testtype.SkipUnlessTestType(t, testtype.IntegrationTestType) | ||
|
|
||
| const dbName = "mongoimport_docvalidation_test" | ||
| const collName = "bar" |
Collaborator
There was a problem hiding this comment.
nit: should probably use consts for testing dbName and collName here and throughout
Collaborator
Author
There was a problem hiding this comment.
I'm a bit confused. This test is using these consts. What do you want me to change?
Collaborator
Author
There was a problem hiding this comment.
Ok, I found the spot you were referring to. This is fixed now.
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
13a71d6 to
fa14a7d
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
2 times, most recently
from
f326567 to
b62485f
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
fa14a7d to
5fe7f70
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
2 times, most recently
from
dbe9a92 to
37dd895
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
branch
from
5fe7f70 to
6c07332
Compare
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
from
37dd895 to
da8ef32
Compare
Collaborator
Author
autarch
changed the base branch from
03-23-convert_test/qa-tests/jstests/import/fields.js_to_go
to
graphite-base/953
autarch
force-pushed
the
03-24-convert_test/qa-tests/jstests/import/import_document_validation.js_to_go
branch
from
da8ef32 to
6e4e836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.