Skip to content

TOOLS-4148 Add a BeforeTest hook for integration suites that drops all existing DBs#980

Open
autarch wants to merge 1 commit into03-31-convert_all_tests_in_integration_to_use_the_testify_suite_packagefrom
04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs
Open

TOOLS-4148 Add a BeforeTest hook for integration suites that drops all existing DBs#980
autarch wants to merge 1 commit into03-31-convert_all_tests_in_integration_to_use_the_testify_suite_packagefrom
04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs

Conversation

@autarch
Copy link
Copy Markdown
Collaborator

@autarch autarch commented Apr 1, 2026

This ensures that the cluster is free of stuff created by previous tests. But this means that we must run these tests sequentially, so that the BeforeTest hook doesn't delete the data for another test running at the same time.

This PR also removes a lot of ad-hoc cleanup that was being done in individual test methods.

@autarch autarch changed the base branch from 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package to graphite-base/980 April 3, 2026 22:18
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from ad17d4d to 65024ea Compare April 3, 2026 22:23
@autarch autarch force-pushed the graphite-base/980 branch from 323143c to e8844d7 Compare April 3, 2026 22:23
@autarch autarch changed the base branch from graphite-base/980 to 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package April 3, 2026 22:23
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from 65024ea to ad0afdf Compare April 3, 2026 22:24
@autarch autarch changed the base branch from 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package to graphite-base/980 April 8, 2026 16:03
@autarch autarch force-pushed the graphite-base/980 branch from e8844d7 to 9842ff5 Compare April 8, 2026 16:04
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from ad0afdf to 79c4323 Compare April 8, 2026 16:04
@autarch autarch changed the base branch from graphite-base/980 to 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package April 8, 2026 16:04
@autarch autarch changed the base branch from 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package to graphite-base/980 April 8, 2026 16:05
@autarch autarch force-pushed the graphite-base/980 branch from 9842ff5 to 4af151d Compare April 8, 2026 16:05
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from 79c4323 to 144980a Compare April 8, 2026 16:05
@autarch autarch changed the base branch from graphite-base/980 to 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package April 8, 2026 16:05
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch 2 times, most recently from 834519c to c0b51fa Compare April 8, 2026 20:39
@autarch autarch force-pushed the 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package branch from 4af151d to b907c8a Compare April 8, 2026 20:39
@autarch autarch force-pushed the 03-31-convert_all_tests_in_integration_to_use_the_testify_suite_package branch 2 times, most recently from fb5a1b5 to 098c623 Compare April 8, 2026 21:12
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from c0b51fa to cd10783 Compare April 8, 2026 21:12
@autarch autarch changed the title Add a BeforeTest hook for integration suites that drops all existing DBs TOOLS-4148 Add a BeforeTest hook for integration suites that drops all existing DBs Apr 8, 2026
…g DBs

This ensures that the cluster is free of stuff created by previous tests.
@autarch autarch force-pushed the 04-01-add_a_beforetest_hook_for_integration_suites_that_drops_all_existing_dbs branch from cd10783 to bd240f8 Compare April 8, 2026 21:19
@autarch autarch requested a review from mmcclimon April 8, 2026 21:19
@autarch autarch marked this pull request as ready for review April 8, 2026 21:19
@autarch autarch requested a review from a team as a code owner April 8, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant